build: Enable -fwhole-program-vtables under ThinLTO.

build: Enable -fwhole-program-vtables under ThinLTO.

This feature has been supported under ThinLTO for some time now.

BUG=660216
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2890573002
Cr-Commit-Position: refs/heads/master@{#472304}
Committed: https://chromium.googlesource.com/chromium/src/+/a2adba27e3ef69283f5060c04c4e64b02bb6ea4d

[pcc1, 2017-05-16 19:49:16]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 19:51:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-16 19:51:19]

lgtm

https://codereview.chromium.org/2890573002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2890573002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:509: if (is_mac) {
Huh, why do we have mac stuff in here? We don't use LTO on mac, do we?

[pcc1, 2017-05-16 19:57:33]

https://codereview.chromium.org/2890573002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2890573002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:509: if (is_mac) {
I think this is from some early work I did to try to support LTO on Mac
(crbug.com/471146). I'd be fine with removing it, we can always bring it back
later.

[commit-bot: I haz the power, 2017-05-16 23:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:17:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pcc1, 2017-05-16 23:18:22]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:19:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:35:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494976702490670, "parent_rev":
"1c2f3f0b21b2e0eefe0e76e5f519a30970933202", "commit_rev":
"a2adba27e3ef69283f5060c04c4e64b02bb6ea4d"}

[commit-bot: I haz the power, 2017-05-17 03:36:08]

Description was changed from

==========
build: Enable -fwhole-program-vtables under ThinLTO.

This feature has been supported under ThinLTO for some time now.

BUG=660216
R=thakis@chromium.org
==========

to

==========
build: Enable -fwhole-program-vtables under ThinLTO.

This feature has been supported under ThinLTO for some time now.

BUG=660216
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2890573002
Cr-Commit-Position: refs/heads/master@{#472304}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2adba27e3ef69283f5060c04c4e...
==========

[commit-bot: I haz the power, 2017-05-17 03:36:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2adba27e3ef69283f5060c04c4e...