Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3065)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_manager.cc

Issue 2890563003: VR: Update UiSceneManager with audio/video capturing flags (Closed)
Patch Set: Use ui_ in VrShell Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_scene_manager.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager.cc b/chrome/browser/android/vr_shell/ui_scene_manager.cc
index 07473440f51ecc6e0dcce1ea41d85527d5de9985..ce7159be8465262f26eb1dfea7b8ce0f8df47195 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager.cc
@@ -120,7 +120,7 @@ void UiSceneManager::CreateSystemIndicators() {
element->set_translation({-0.3, 0.8, -1.9});
element->set_size({0.4, 0, 1});
element->set_visible(false);
- audio_input_indicator_ = element.get();
+ audio_capture_indicator_ = element.get();
scene_->AddUiElement(std::move(element));
element = base::MakeUnique<VideoCaptureIndicator>(256);
@@ -128,7 +128,7 @@ void UiSceneManager::CreateSystemIndicators() {
element->set_translation({0.3, 0.8, -1.9});
element->set_size({0.4, 0, 1});
element->set_visible(false);
- video_input_indicator_ = element.get();
+ video_capture_indicator_ = element.get();
scene_->AddUiElement(std::move(element));
}
@@ -288,6 +288,18 @@ void UiSceneManager::ConfigureScene() {
-kBackgroundDistanceMultiplier);
}
+void UiSceneManager::SetAudioCapturingIndicator(bool enabled) {
+ audio_capture_indicator_->set_visible(enabled);
cjgrant 2017/05/16 21:31:38 As of now, theses will show up in WebVR. You coul
amp 2017/05/16 22:24:44 Is there a possibility that they need to show up i
asimjour1 2017/05/17 14:42:20 This looks to be out of scope of this CL. I'll sta
cjgrant 2017/05/17 14:57:31 If they do show up in WebVR, presumably they have
+}
+
+void UiSceneManager::SetVideoCapturingIndicator(bool enabled) {
+ video_capture_indicator_->set_visible(enabled);
+}
+
+void UiSceneManager::SetScreenCapturingIndicator(bool enabled) {
+ // TODO(asimjour) add the indicator and change the visibility here.
+}
+
void UiSceneManager::SetWebVrSecureOrigin(bool secure) {
secure_origin_ = secure;
ConfigureSecurityWarnings();

Powered by Google App Engine
This is Rietveld 408576698