VR: Update UiSceneManager with audio/video capturing flags

chrome/browser/android/vr_shell/ui_scene_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene_manager.h"
 
 #include "base/callback.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/android/vr_shell/textures/ui_texture.h"
 #include "chrome/browser/android/vr_shell/ui_elements/audio_capture_indicator.h"
@@ skipping 102 matching lines @@
 void UiSceneManager::CreateSystemIndicators() {
   std::unique_ptr<UiElement> element;
 
   // TODO(acondor): Make constants for sizes and positions once the UX for the
   // indicators is defined.
   element = base::MakeUnique<AudioCaptureIndicator>(256);
   element->set_id(AllocateId());
   element->set_translation({-0.3, 0.8, -1.9});
   element->set_size({0.4, 0, 1});
   element->set_visible(false);
-  audio_input_indicator_ = element.get();
+  audio_capture_indicator_ = element.get();
   scene_->AddUiElement(std::move(element));
 
   element = base::MakeUnique<VideoCaptureIndicator>(256);
   element->set_id(AllocateId());
   element->set_translation({0.3, 0.8, -1.9});
   element->set_size({0.4, 0, 1});
   element->set_visible(false);
-  video_input_indicator_ = element.get();
+  video_capture_indicator_ = element.get();
   scene_->AddUiElement(std::move(element));
 }
 
 void UiSceneManager::CreateContentQuad() {
   std::unique_ptr<UiElement> element;
 
   element = base::MakeUnique<UiElement>();
   element->set_id(AllocateId());
   element->set_fill(vr_shell::Fill::CONTENT);
   element->set_size({kContentWidth, kContentHeight, 1});
@@ skipping 139 matching lines @@
     // Note that main_content_ is already visible in this case.
     main_content_->set_translation(
         {0, kContentVerticalOffset, -kContentDistance});
     main_content_->set_size({kContentWidth, kContentHeight, 1});
   }
 
   scene_->SetBackgroundDistance(main_content_->translation().z() *
                                 -kBackgroundDistanceMultiplier);
 }
 
+void UiSceneManager::SetAudioCapturingIndicator(bool enabled) {
+  audio_capture_indicator_->set_visible(enabled);

[cjgrant, 2017/05/16 21:31:38]

As of now, theses will show up in WebVR.  You could:
- Make an indicator class that takes "enabled" and "in_web_vr" to set its own
visibility, or
- Do some specific logic like the HTTP warnings do (ie. logic lives in the scene
manager)

[amp, 2017/05/16 22:24:44]

Is there a possibility that they need to show up in WebVR?

Who makes that call, security?

[asimjour1, 2017/05/17 14:42:20]

This looks to be out of scope of this CL. I'll start a bug to track this issue.

[cjgrant, 2017/05/17 14:57:31]

If they do show up in WebVR, presumably they have to be headlocked as well.

+}
+
+void UiSceneManager::SetVideoCapturingIndicator(bool enabled) {
+  video_capture_indicator_->set_visible(enabled);
+}
+
+void UiSceneManager::SetScreenCapturingIndicator(bool enabled) {
+  // TODO(asimjour) add the indicator and change the visibility here.
+}
+
 void UiSceneManager::SetWebVrSecureOrigin(bool secure) {
   secure_origin_ = secure;
   ConfigureSecurityWarnings();
 }
 
 void UiSceneManager::OnAppButtonClicked() {
   // App button click exits the WebVR presentation and fullscreen.
   browser_->ExitPresent();
   browser_->ExitFullscreen();
 }
@@ skipping 48 matching lines @@
 void UiSceneManager::SetHistoryButtonsEnabled(bool can_go_back,
                                               bool can_go_forward) {}
 
 void UiSceneManager::OnCloseButtonClicked() {}
 
 int UiSceneManager::AllocateId() {
   return next_available_id_++;
 }
 
 }  // namespace vr_shell