Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2890543002: Improve LayoutTable outer collapsed border calculation (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve LayoutTable outer collapsed border calculation Remove code in LayoutTable and LayoutTableSection for computing outer borders. Use cells' cached collapsed borders instead.

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -625 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 6 chunks +18 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 12 chunks +112 lines, -255 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 2 chunks +22 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 7 chunks +60 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 2 chunks +0 lines, -145 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSectionTest.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
A third_party/WebKit/Source/core/layout/LayoutTableTest.cpp View 1 2 1 chunk +162 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2884763003 Patch 20001

Messages

Total messages: 8 (8 generated)
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-16 17:48:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890543002/20001
3 years, 7 months ago (2017-05-16 17:49:39 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-16 17:56:04 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/270144) mac_chromium_rel_ng on ...
3 years, 7 months ago (2017-05-16 17:56:05 UTC) #4
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-16 18:01:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890543002/40001
3 years, 7 months ago (2017-05-16 18:03:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-16 20:17:01 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 20:17:02 UTC) #8 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698