Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2890543002: Improve LayoutTable outer collapsed border calculation (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.h b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
index da64479afd32db6563e2f8d18e5cb442e7e5b726..e4e771f28189374f13f69f392a9a721317479bb9 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
@@ -357,6 +357,20 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
return cell1->RowIndex() < cell2->RowIndex();
}
+ // For LayoutTable to compute its collapsed outer borders.
+ unsigned CollapsedOuterBorderBefore() const {
+ return CollapsedBorderHalfBefore(true);
+ }
+ unsigned CollapsedOuterBorderAfter() const {
+ return CollapsedBorderHalfAfter(true);
+ }
+ unsigned CollapsedOuterBorderStart() const {
+ return CollapsedBorderHalfStart(true);
+ }
+ unsigned CollapsedOuterBorderEnd() const {
+ return CollapsedBorderHalfEnd(true);
+ }
+
protected:
void StyleDidChange(StyleDifference, const ComputedStyle* old_style) override;
void ComputePreferredLogicalWidths() override;
@@ -391,15 +405,15 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
bool recompute_floats = false) override;
LayoutRect LocalVisualRect() const override;
- LayoutUnit CollapsedBorderHalfLeft(bool outer) const;
- LayoutUnit CollapsedBorderHalfRight(bool outer) const;
- LayoutUnit CollapsedBorderHalfTop(bool outer) const;
- LayoutUnit CollapsedBorderHalfBottom(bool outer) const;
+ unsigned CollapsedBorderHalfLeft(bool outer) const;
+ unsigned CollapsedBorderHalfRight(bool outer) const;
+ unsigned CollapsedBorderHalfTop(bool outer) const;
+ unsigned CollapsedBorderHalfBottom(bool outer) const;
- LayoutUnit CollapsedBorderHalfStart(bool outer) const;
- LayoutUnit CollapsedBorderHalfEnd(bool outer) const;
- LayoutUnit CollapsedBorderHalfBefore(bool outer) const;
- LayoutUnit CollapsedBorderHalfAfter(bool outer) const;
+ unsigned CollapsedBorderHalfStart(bool outer) const;
+ unsigned CollapsedBorderHalfEnd(bool outer) const;
+ unsigned CollapsedBorderHalfBefore(bool outer) const;
+ unsigned CollapsedBorderHalfAfter(bool outer) const;
void SetIntrinsicPaddingBefore(int p) { intrinsic_padding_before_ = p; }
void SetIntrinsicPaddingAfter(int p) { intrinsic_padding_after_ = p; }
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698