Issue 289053002: Revert 270766 "[telemetry] Make testMeasurementSmoke generate se..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289053002: Revert 270766 "[telemetry] Make testMeasurementSmoke generate se..." (Closed)

Created:
6 years, 7 months ago by jiayl

Modified:
6 years, 7 months ago

Reviewers:
dtu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 270766 "[telemetry] Make testMeasurementSmoke generate se..." Causing Android Tests failure in telemetry_perf_unittests. > [telemetry] Make testMeasurementSmoke generate separate tests. > > This way failures in one benchmark won't stop the rest of the tests, and it'll print separate GTest steps for each benchmark. > The test names follow the format BenchmarkSmokeTest.benchmark.name so you can still find BenchmarkSmokeTest with a search. > > Also: > - Rename it to the more apt BenchmarkSmoke. > - Print Chrome stack trace when there's a tab crash at Chrome startup. > > > BUG=368401, 371613, 373385 > TEST=tools/perf/run_tests benchmark > NOTRY=true > > Review URL: https://codereview.chromium.org/287773002 TBR=dtu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270798

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -96 lines)			Patch
D	trunk/src/tools/perf/benchmarks/benchmark_unittest.py	View	1 chunk	+0 lines, -90 lines	0 comments	Download
A +	trunk/src/tools/perf/measurements/measurement_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/page/gtest_test_results.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/page/page_runner.py	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jiayl

6 years, 7 months ago (2014-05-15 20:32:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r270798 (tree was closed).

Expand Messages | Collapse Messages