Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 287773002: [telemetry] Make testMeasurementSmoke generate separate tests. (Closed)

Created:
6 years, 7 months ago by dtu
Modified:
6 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[telemetry] Make testMeasurementSmoke generate separate tests. This way failures in one benchmark won't stop the rest of the tests, and it'll print separate GTest steps for each benchmark. The test names follow the format BenchmarkSmokeTest.benchmark.name so you can still find BenchmarkSmokeTest with a search. Also rename it to the more apt BenchmarkSmokeTest. BUG=368401 TEST=tools/perf/run_tests benchmark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270766 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273712

Patch Set 1 : #

Patch Set 2 : Add stack trace if tab crash during browser startup. #

Patch Set 3 : Fix @Disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -74 lines) Patch
A tools/perf/benchmarks/benchmark_unittest.py View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
D tools/perf/measurements/measurement_unittest.py View 1 chunk +0 lines, -73 lines 0 comments Download
M tools/telemetry/telemetry/page/gtest_test_results.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
dtu
6 years, 7 months ago (2014-05-14 23:20:00 UTC) #1
tonyg
lgtm
6 years, 7 months ago (2014-05-15 06:45:26 UTC) #2
tonyg
The CQ bit was unchecked by tonyg@chromium.org
6 years, 7 months ago (2014-05-15 06:46:09 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 7 months ago (2014-05-15 07:02:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/287773002/60001
6 years, 7 months ago (2014-05-15 07:03:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 10:14:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 10:18:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67850)
6 years, 7 months ago (2014-05-15 10:18:25 UTC) #8
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 7 months ago (2014-05-15 11:20:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/287773002/60001
6 years, 7 months ago (2014-05-15 11:21:05 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 11:42:36 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 11:46:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67855)
6 years, 7 months ago (2014-05-15 11:46:27 UTC) #13
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 7 months ago (2014-05-15 19:07:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/287773002/60001
6 years, 7 months ago (2014-05-15 19:09:02 UTC) #15
commit-bot: I haz the power
Change committed as 270766
6 years, 7 months ago (2014-05-15 19:11:00 UTC) #16
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 6 months ago (2014-05-29 22:44:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/287773002/80001
6 years, 6 months ago (2014-05-29 22:45:46 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 03:58:20 UTC) #19
Message was sent while issue was closed.
Change committed as 273712

Powered by Google App Engine
This is Rietveld 408576698