Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2890523002: merge fasta.Token into analyzer.Token (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

merge fasta.Token into analyzer.Token This eliminates much of the duplication between the two token hierarchies by merging much of the fasta.Token hierarchy into the analyzer.Token. * merge token hierarchies * cleanup fasta.Token.copy() * set preceedingComments field via constructor * replace isBuiltInIdentifier --> type.isBuiltIn * change all fasta.Token references to analyzer.Token * move fasta.Token.value() implementation into analyzer.SimpleToken R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/278c7bfbeb7361d35ff9738816181d148b10b97a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -372 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/token_utils.dart View 7 chunks +41 lines, -35 lines 0 comments Download
M pkg/analyzer/lib/src/summary/fasta/stack_listener.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/mini_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/fasta_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/class_member_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 4 chunks +5 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser_main.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/token_stream_rewriter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/top_level_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 6 chunks +8 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/error_token.dart View 3 chunks +5 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/string_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 11 chunks +46 lines, -223 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/directive_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/scope_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/unhandled_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/scanner/errors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 5 chunks +18 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/parser/token_stream_rewriter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/precedence_info_test.dart View 13 chunks +13 lines, -13 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/front_end/test/token_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 7 months ago (2017-05-16 15:37:00 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-16 15:44:11 UTC) #3
danrubel
3 years, 7 months ago (2017-05-16 15:50:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
278c7bfbeb7361d35ff9738816181d148b10b97a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698