Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2823)

Unified Diff: pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart

Issue 2890523002: merge fasta.Token into analyzer.Token (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart
diff --git a/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart b/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart
index 20896425be2fc510f1bff297cf008b04d6be06dd..8b88326a6a9b0d4d641889a213011a45969d631c 100644
--- a/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart
+++ b/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart
@@ -8,7 +8,7 @@ import 'dart:collection' show ListMixin;
import 'dart:typed_data' show Uint16List, Uint32List;
-import '../../scanner/token.dart' show TokenType;
+import '../../scanner/token.dart' show Token, TokenType;
import '../scanner.dart'
show ErrorToken, Keyword, Scanner, buildUnexpectedCharacterToken;
@@ -18,7 +18,7 @@ import 'error_token.dart' show UnterminatedToken;
import 'keyword_state.dart' show KeywordState;
import 'token.dart'
- show BeginGroupToken, CommentToken, DartDocToken, SymbolToken, Token;
+ show BeginGroupToken, CommentToken, DartDocToken, SymbolToken;
import 'token_constants.dart';
@@ -870,10 +870,9 @@ abstract class AbstractScanner implements Scanner {
tail.next.previous = tail;
tail = tail.next;
if (comments != null) {
- for (CommentToken c = comments; c != null; c = c.next) {
- c.parent = tail;
- }
- tail.precedingComments = comments;
+ // It is the responsibility of the caller to construct the token
+ // being appended with preceeding comments if any
+ assert(identical(token.precedingComments, comments));
comments = null;
commentsTail = null;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/scanner.dart ('k') | pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698