Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2890503003: Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
Reviewers:
Bryan McQuade, jkarlin
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default (patchset #1 id:1 of https://codereview.chromium.org/2887773003/ ) Reason for revert: Causes the following browser_tests to fail on the Linux ChromiumOS Tests builder PageLoadMetricsBrowserTest.NonHtmlMainResource PageLoadMetricsBrowserTest.Ignore204Pages PageLoadMetricsBrowserTest.HttpErrorPage PageLoadMetricsBrowserTest.IgnoreDownloads BUG=723219 Original issue's description: > [PageLoadMetrics] Enable AdsPageLoadMetrics by default > > Now that we've addressed all of the known causes of crashes, it's time to > reenable. > > BUG=708570 > > Review-Url: https://codereview.chromium.org/2887773003 > Cr-Commit-Position: refs/heads/master@{#472248} > Committed: https://chromium.googlesource.com/chromium/src/+/6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26 TBR=bmcquade@chromium.org,jkarlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
afakhry
Created Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default
3 years, 7 months ago (2017-05-17 02:04:50 UTC) #2
Bryan McQuade
On 2017/05/17 at 02:04:50, afakhry wrote: > Created Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default ...
3 years, 7 months ago (2017-05-17 02:06:57 UTC) #4
afakhry
3 years, 7 months ago (2017-05-17 02:08:41 UTC) #5
Message was sent while issue was closed.
On 2017/05/17 02:06:57, Bryan McQuade wrote:
> On 2017/05/17 at 02:04:50, afakhry wrote:
> > Created Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default
> 
> There's already a revert in flight for this:
> https://codereview.chromium.org/2890603005/ so I canceled this commit.

Yep, we both created the revert at the same time. Thanks. Closing this issue.

Powered by Google App Engine
This is Rietveld 408576698