Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2890413003: Explicitly use bool instead of jboolean (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly use bool instead of jboolean jboolean is an uint8_t BUG=724593 Review-Url: https://codereview.chromium.org/2890413003 Cr-Commit-Position: refs/heads/master@{#473343} Committed: https://chromium.googlesource.com/chromium/src/+/325ebde8666ef8618bde2d1e9eeceb623030ac49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/rlz/rlz_ping_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 7 months ago (2017-05-19 20:31:46 UTC) #2
Yusuf
lgtm
3 years, 7 months ago (2017-05-19 20:40:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890413003/1
3 years, 7 months ago (2017-05-19 20:41:21 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 21:50:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/325ebde8666ef8618bde2d1e9eec...

Powered by Google App Engine
This is Rietveld 408576698