Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2890403002: Introduce Position::IsEquivalent() (Closed)

Created:
3 years, 7 months ago by yosin_UTC9
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Introduce Position::IsEquivalent() This patch introduces |Position::IsEquivalent()| to check whether two positions are in same position regardless anchor type, e.g. |Position(node, 0)| and |Position::FirstPositionInNode(node)|. denote a position before first child of |node|. This patch is a preparation of patch[1]. [1] http://crrev.com/2875933004: Utilize Position::IsEquivalent() in {Up,Down}streamIgnoringEditingBoundaries() BUG=716093, 719343 TEST=run_webkit_unit_tests --gtest_filter=PositionTest.IsEquivalent Review-Url: https://codereview.chromium.org/2875253002 Cr-Original-Commit-Position: refs/heads/master@{#471689} Review-Url: https://codereview.chromium.org/2890403002 . Cr-Commit-Position: refs/branch-heads/3071@{#628} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b67267c9b096b7ac8fd187bccd91178c04689e32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionTest.cpp View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yosin_UTC9
3 years, 7 months ago (2017-05-19 10:30:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b67267c9b096b7ac8fd187bccd91178c04689e32.

Powered by Google App Engine
This is Rietveld 408576698