Bootstrapping: Send meaningful error code/message from Slave to Master

chrome/browser/chromeos/login/helper.h

Index: chrome/browser/chromeos/login/helper.h
diff --git a/chrome/browser/chromeos/login/helper.h b/chrome/browser/chromeos/login/helper.h
index f3ebd2fad49f6642e86bf32b9c3a79935dd58740..2db275cb65af6eba08182738938e60b2973b8cf9 100644
--- a/chrome/browser/chromeos/login/helper.h
+++ b/chrome/browser/chromeos/login/helper.h
@@ -12,6 +12,7 @@
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
+#include "chromeos/network/network_handler_callbacks.h"

[achuithb, 2017/05/25 19:25:53]

Please forward declare ErrorCallback instead

[xdai1, 2017/06/08 22:18:40]

It's a type def so can't be forward declared.

 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/views/view.h"
 
@@ -73,7 +74,7 @@ class NetworkStateHelper {
   virtual void CreateAndConnectNetworkFromOnc(
       const std::string& onc_spec,
       const base::Closure& success_callback,
-      const base::Closure& error_callback) const;
+      const network_handler::ErrorCallback& error_callback) const;
 
   // Returns true if the default network is in connected state.
   virtual bool IsConnected() const;
@@ -82,14 +83,11 @@ class NetworkStateHelper {
   virtual bool IsConnecting() const;
 
  private:
-  void OnCreateConfiguration(const base::Closure& success_callback,
-                             const base::Closure& error_callback,
-                             const std::string& service_path,
-                             const std::string& guid) const;
-  void OnCreateOrConnectNetworkFailed(
-      const base::Closure& error_callback,
-      const std::string& error_name,
-      std::unique_ptr<base::DictionaryValue> error_data) const;
+  void OnCreateConfiguration(
+      const base::Closure& success_callback,
+      const network_handler::ErrorCallback& error_callback,
+      const std::string& service_path,
+      const std::string& guid) const;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkStateHelper);
 };