Refactoring: Extract some logic from RebaselineCL.execute.

Refactoring: Extract some logic from RebaselineCL.execute.

Specifically, this CL extracts the methods:

  _log_pending_builds
  _make_test_baseline_set_for_tests

And modifies trigger_builds.

The purpose of this change is to simplify the main execute() method and move some details into helper methods.

Review-Url: https://codereview.chromium.org/2890373003
Cr-Commit-Position: refs/heads/master@{#473346}
Committed: https://chromium.googlesource.com/chromium/src/+/aac9fbb89108a6c02e3b491bab4de977fec77e69

[qyearsley, 2017-05-19 18:55:23]

Description was changed from

==========
Refactoring: Extract some logic from RebaselineCL.execute.
==========

to

==========
Refactoring: Extract some logic from RebaselineCL.execute.

Specifically, this CL extracts the methods:

  _log_pending_builds
  _make_test_baseline_set_for_tests

And modifies trigger_builds.

The purpose of this change is to simplify the main execute() method and move
some details into helper methods.
==========

[qyearsley, 2017-05-19 18:55:23]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-05-19 18:55:31]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:56:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jeffcarp, 2017-05-19 20:21:45]

lgtm

https://codereview.chromium.org/2890373003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
(right):

https://codereview.chromium.org/2890373003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:71: if
triggered:
Could these two lines be collapsed?

[qyearsley, 2017-05-19 20:39:03]

https://codereview.chromium.org/2890373003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
(right):

https://codereview.chromium.org/2890373003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:71: if
triggered:
On 2017/05/19 at 20:21:45, jeffcarp wrote:
> Could these two lines be collapsed?

Yep, and that would be a bit nicer I think; done.

[qyearsley, 2017-05-19 20:39:06]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-05-19 20:39:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2890373003/#ps20001
(title: "collapse")

[commit-bot: I haz the power, 2017-05-19 20:39:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:56:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495226346350910,
"parent_rev": "8ee9280525895b4dbb74d3e6117547f79b96d89e", "commit_rev":
"aac9fbb89108a6c02e3b491bab4de977fec77e69"}

[commit-bot: I haz the power, 2017-05-19 21:56:21]

Description was changed from

==========
Refactoring: Extract some logic from RebaselineCL.execute.

Specifically, this CL extracts the methods:

  _log_pending_builds
  _make_test_baseline_set_for_tests

And modifies trigger_builds.

The purpose of this change is to simplify the main execute() method and move
some details into helper methods.
==========

to

==========
Refactoring: Extract some logic from RebaselineCL.execute.

Specifically, this CL extracts the methods:

  _log_pending_builds
  _make_test_baseline_set_for_tests

And modifies trigger_builds.

The purpose of this change is to simplify the main execute() method and move
some details into helper methods.

Review-Url: https://codereview.chromium.org/2890373003
Cr-Commit-Position: refs/heads/master@{#473346}
Committed:
https://chromium.googlesource.com/chromium/src/+/aac9fbb89108a6c02e3b491bab4d...
==========

[commit-bot: I haz the power, 2017-05-19 21:56:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aac9fbb89108a6c02e3b491bab4d...