Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2890313003: Commands preserve handles (Closed)
Patch Set: added test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index e3f650ec241b54c203497dd8219f0677e3a41f48..54465f36a806475963a88164770396b88c785957 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -124,8 +124,8 @@ operator=(const VisibleSelectionTemplate<Strategy>& other) {
}
template <typename Strategy>
-SelectionTemplate<Strategy> VisibleSelectionTemplate<Strategy>::AsSelection()
- const {
+SelectionTemplate<Strategy> VisibleSelectionTemplate<Strategy>::AsSelection(
+ bool is_handle_visible) const {
typename SelectionTemplate<Strategy>::Builder builder;
if (base_.IsNotNull())
builder.SetBaseAndExtent(base_, extent_);
@@ -133,6 +133,7 @@ SelectionTemplate<Strategy> VisibleSelectionTemplate<Strategy>::AsSelection()
.SetGranularity(granularity_)
.SetIsDirectional(is_directional_)
.SetHasTrailingWhitespace(has_trailing_whitespace_)
+ .SetIsHandleVisible(is_handle_visible)
.Build();
}

Powered by Google App Engine
This is Rietveld 408576698