third_party/WebKit/Source/core/editing/VisibleSelection.h - Issue 2890313003: Commands preserve handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2890313003: Commands preserve handles (Closed)

Patch Set: added test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelection.h

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h

index 37d60f7eff87dd654b71daf32c2f7ca55aaa3df4..618a148bd27c2d417a895b384330b04ceae74987 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h

@@ -65,7 +65,7 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {

TextAffinity Affinity() const { return affinity_; }

- SelectionTemplate<Strategy> AsSelection() const;

+ SelectionTemplate<Strategy> AsSelection(bool is_handle_visible = false) const;

PositionTemplate<Strategy> Base() const { return base_; }

PositionTemplate<Strategy> Extent() const { return extent_; }

PositionTemplate<Strategy> Start() const { return start_; }