Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2890303003: desktopCapture: set the correct videoTrack label according to the capture type (Closed)

Created:
3 years, 7 months ago by braveyao
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

desktopCapture: set the correct videoTrack label according to the capture type Currently during desktopCature we always set vieoTrack label as "screen" to all the screen/window/tab capture. This cl is to set the label with correct prefix to each capture type, i.e. screen capture -- screen:x:x window capture -- window:x:x tab capture -- web-contents-media-stream:x:x BUG=724668 Review-Url: https://codereview.chromium.org/2890303003 Cr-Commit-Position: refs/heads/master@{#473529} Committed: https://chromium.googlesource.com/chromium/src/+/5bcd03be11700eb3bd3755593f5a07530940e789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/media/webrtc/desktop_capture_access_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
braveyao
Hi tommi@, please take a look.
3 years, 7 months ago (2017-05-19 23:49:07 UTC) #7
tommi (sloooow) - chröme
lgtm
3 years, 7 months ago (2017-05-22 08:12:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890303003/1
3 years, 7 months ago (2017-05-22 08:13:18 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 09:04:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bcd03be11700eb3bd3755593f5a...

Powered by Google App Engine
This is Rietveld 408576698