Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2890293005: Network traffic annotation stored in url_request. (Closed)

Created:
3 years, 7 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
CC:
asanka, battre, cbentzel+watch_chromium.org, chromium-reviews, msramek, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation stored in url_request. Network traffic annotation tags are stored in url_request. BUG=656607 Review-Url: https://codereview.chromium.org/2890293005 Cr-Commit-Position: refs/heads/master@{#473874} Committed: https://chromium.googlesource.com/chromium/src/+/0e2a2278827bd1ef68423438211030a22b60e331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -56 lines) Patch
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/gaia/mock_url_fetcher_factory.h View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow_unittest.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M ios/chrome/test/app/signin_test_util.mm View 3 chunks +5 lines, -3 lines 0 comments Download
M net/traffic_annotation/network_traffic_annotation.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/url_request/test_url_fetcher_factory.h View 4 chunks +7 lines, -3 lines 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M net/url_request/url_fetcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_fetcher_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request.h View 4 chunks +10 lines, -1 line 0 comments Download
M net/url_request/url_request.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 38 (32 generated)
Ramin Halavati
Helen, This CL adds unique id of network traffic annotations to URLRequest. Please review.
3 years, 7 months ago (2017-05-22 14:26:48 UTC) #29
xunjieli
On 2017/05/22 14:26:48, Ramin Halavati wrote: > Helen, > > This CL adds unique id ...
3 years, 7 months ago (2017-05-22 14:34:11 UTC) #30
Ramin Halavati
Thank you Helen. Jochen, This CL stores network annotation tag in URLRequest with would be ...
3 years, 7 months ago (2017-05-23 04:47:15 UTC) #32
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-23 11:14:41 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890293005/120002
3 years, 7 months ago (2017-05-23 11:33:11 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 13:10:48 UTC) #38
Message was sent while issue was closed.
Committed patchset #1 (id:120002) as
https://chromium.googlesource.com/chromium/src/+/0e2a2278827bd1ef684234382110...

Powered by Google App Engine
This is Rietveld 408576698