Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2890293002: chromeos: Export GetKioskAppRequiredPlatformVersion method. (Closed)

Created:
3 years, 7 months ago by Daniel Erat
Modified:
3 years, 7 months ago
Reviewers:
teravest, birdbrain
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Export GetKioskAppRequiredPlatformVersion method. Continue to export a GetKioskAppRequiredPlatformVersion D-Bus method on org.chromium.LibCrosService. It was accidentally renamed to GetRequiredPlatformVersion (which should only be exported via the new org.chromium.KioskAppService service) by 6e2e787479f5. BUG=703229, 724325 Review-Url: https://codereview.chromium.org/2890293002 Cr-Commit-Position: refs/heads/master@{#473011} Committed: https://chromium.googlesource.com/chromium/src/+/cdf6f91b9e1c389bc6b07bdfb7eb9018ee49d719

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 13 (8 generated)
Daniel Erat
(i haven't tested this, but someone who knows how the method is used can.)
3 years, 7 months ago (2017-05-19 00:06:43 UTC) #2
Daniel Erat
https://codereview.chromium.org/2890293002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/2890293002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#newcode305 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:305: kLibCrosServiceInterface, kGetKioskAppRequiredPlatforVersion)); yes, the constant is named "Platfor". ಠ_ಠ
3 years, 7 months ago (2017-05-19 00:08:38 UTC) #5
teravest
lgtm
3 years, 7 months ago (2017-05-19 00:10:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890293002/1
3 years, 7 months ago (2017-05-19 00:15:07 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 01:18:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdf6f91b9e1c389bc6b07bdfb7eb...

Powered by Google App Engine
This is Rietveld 408576698