EQT: Record the max queueing time from navigation start to navigation away

third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index b3812dc5780262f6b79143108f71885aee99d4b6..81634b693930d41a4b3b8742fccf57cd81ccaafa 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -217,6 +217,12 @@ RendererSchedulerImpl::MainThreadOnly::MainThreadOnly(
       in_idle_period_for_testing(false),
       use_virtual_time(false),
       is_audio_playing(false),
+      max_queuing_time_histogram(
+          base::SingleSampleMetricsFactory::Get()->CreateCustomCountsMetric(
+              "RendererScheduler.MaxQueueingTime",

[tdresser, 2017/05/18 20:42:26]

This needs to line up with the name in histograms.xml.

[Liquan (Max) Gu, 2017/05/19 22:24:26]

Done.

+              1,
+              10000,
+              50)),
       rail_mode_observer(nullptr),
       wake_up_budget_pool(nullptr),
       task_duration_per_queue_type_histogram(base::Histogram::FactoryGet(
@@ -1904,6 +1910,8 @@ void RendererSchedulerImpl::RemoveTaskTimeObserver(
 void RendererSchedulerImpl::OnQueueingTimeForWindowEstimated(
     base::TimeDelta queueing_time,
     base::TimeTicks window_start_time) {
+  GetMainThreadOnly().max_queuing_time_histogram->SetSample(
+      queueing_time.ToInternalValue());

[tdresser, 2017/05/18 20:42:26]

We should be using InMilliseconds(), I think.

[Liquan (Max) Gu, 2017/05/19 22:24:26]

Done.

   // RendererScheduler reports the queueing time once per window's duration.
   //          |stepEQT|stepEQT|stepEQT|stepEQT|stepEQT|stepEQT|
   // Report:  |-------window EQT------|
@@ -1920,6 +1928,7 @@ void RendererSchedulerImpl::OnQueueingTimeForWindowEstimated(
   TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
                  "estimated_queueing_time_for_window",
                  queueing_time.InMillisecondsF());
+

[tdresser, 2017/05/18 20:42:26]

Try to avoid introducing unrelated whitespace changes.

[Liquan (Max) Gu, 2017/05/19 22:24:26]

Done.

   GetMainThreadOnly().uma_last_queueing_time_report_window_start_time =
       window_start_time;
 }