EQT: Record the max queueing time from navigation start to navigation away

third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/scheduler/renderer/renderer_scheduler_impl.h"
 
 #include "base/bind.h"
 #include "base/debug/stack_trace.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
@@ skipping 199 matching lines @@
       timer_tasks_seem_expensive(false),
       touchstart_expected_soon(false),
       have_seen_a_begin_main_frame(false),
       have_reported_blocking_intervention_in_current_policy(false),
       have_reported_blocking_intervention_since_navigation(false),
       has_visible_render_widget_with_touch_handler(false),
       begin_frame_not_expected_soon(false),
       in_idle_period_for_testing(false),
       use_virtual_time(false),
       is_audio_playing(false),
+      max_queuing_time_histogram(
+          base::SingleSampleMetricsFactory::Get()->CreateCustomCountsMetric(
+              "RendererScheduler.MaxQueueingTime",

[tdresser, 2017/05/18 20:42:26]

This needs to line up with the name in histograms.xml.

[Liquan (Max) Gu, 2017/05/19 22:24:26]

Done.

+              1,
+              10000,
+              50)),
       rail_mode_observer(nullptr),
       wake_up_budget_pool(nullptr),
       task_duration_per_queue_type_histogram(base::Histogram::FactoryGet(
           "RendererScheduler.TaskDurationPerQueueType",
           1,
           static_cast<int>(TaskQueue::QueueType::COUNT),
           static_cast<int>(TaskQueue::QueueType::COUNT) + 1,
           base::HistogramBase::kUmaTargetedHistogramFlag)) {
   foreground_main_thread_load_tracker.Resume(now);
 }
@@ skipping 1430 matching lines @@
   DCHECK(!GetMainThreadOnly().renderer_backgrounded ||
          (GetMainThreadOnly().renderer_backgrounded &&
           !GetMainThreadOnly().renderer_suspended));
   if (!GetMainThreadOnly().timer_queue_suspended_when_backgrounded)
     return;
 
   GetMainThreadOnly().timer_queue_suspended_when_backgrounded = false;
   ForceUpdatePolicy();
 }
 
 void RendererSchedulerImpl::ResetForNavigationLocked() {

[tdresser, 2017/05/18 20:42:26]

We should flush the histogram in here.

[Liquan (Max) Gu, 2017/05/19 22:24:26]

Done.

   helper_.CheckOnValidThread();
   any_thread_lock_.AssertAcquired();
   GetAnyThread().user_model.Reset(helper_.scheduler_tqm_delegate()->NowTicks());
   GetAnyThread().have_seen_a_potentially_blocking_gesture = false;
   GetAnyThread().waiting_for_meaningful_paint = true;
   GetAnyThread().have_seen_input_since_navigation = false;
   GetMainThreadOnly().loading_task_cost_estimator.Clear();
   GetMainThreadOnly().timer_task_cost_estimator.Clear();
   GetMainThreadOnly().idle_time_estimator.Clear();
   GetMainThreadOnly().have_seen_a_begin_main_frame = false;
@@ skipping 216 matching lines @@
 }
 
 void RendererSchedulerImpl::RemoveTaskTimeObserver(
     TaskTimeObserver* task_time_observer) {
   helper_.RemoveTaskTimeObserver(task_time_observer);
 }
 
 void RendererSchedulerImpl::OnQueueingTimeForWindowEstimated(
     base::TimeDelta queueing_time,
     base::TimeTicks window_start_time) {
+  GetMainThreadOnly().max_queuing_time_histogram->SetSample(
+      queueing_time.ToInternalValue());

[tdresser, 2017/05/18 20:42:26]

We should be using InMilliseconds(), I think.

[Liquan (Max) Gu, 2017/05/19 22:24:26]

Done.

   // RendererScheduler reports the queueing time once per window's duration.
   //          |stepEQT|stepEQT|stepEQT|stepEQT|stepEQT|stepEQT|
   // Report:  |-------window EQT------|
   // Discard:         |-------window EQT------|
   // Discard:                 |-------window EQT------|
   // Report:                          |-------window EQT------|
   if (window_start_time -
           GetMainThreadOnly().uma_last_queueing_time_report_window_start_time <
       kQueueingTimeWindowDuration) {
     return;
   }
   UMA_HISTOGRAM_TIMES("RendererScheduler.ExpectedTaskQueueingDuration",
                       queueing_time);
   TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
                  "estimated_queueing_time_for_window",
                  queueing_time.InMillisecondsF());
+

[tdresser, 2017/05/18 20:42:26]

Try to avoid introducing unrelated whitespace changes.

[Liquan (Max) Gu, 2017/05/19 22:24:26]

Done.

   GetMainThreadOnly().uma_last_queueing_time_report_window_start_time =
       window_start_time;
 }
 
 AutoAdvancingVirtualTimeDomain* RendererSchedulerImpl::GetVirtualTimeDomain() {
   if (!virtual_time_domain_) {
     virtual_time_domain_.reset(
         new AutoAdvancingVirtualTimeDomain(tick_clock()->NowTicks()));
     RegisterTimeDomain(virtual_time_domain_.get());
   }
@@ skipping 121 matching lines @@
     case TimeDomainType::VIRTUAL:
       return "virtual";
     default:
       NOTREACHED();
       return nullptr;
   }
 }
 
 }  // namespace scheduler
 }  // namespace blink