[ObjC ARC] Converts ios/chrome/browser/ui/static_content:static_content to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/static_content:static_content to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2890163003
Cr-Commit-Position: refs/heads/master@{#476340}
Committed: https://chromium.googlesource.com/chromium/src/+/874f0e98a9fa5bcb368ae3582232d0e5506bcc54

[lindsayw, 2017-05-18 15:37:55]

The CQ bit was checked by lindsayw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 15:38:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:49:01]

Dry run: This issue passed the CQ dry run.

[lindsayw, 2017-05-18 19:05:53]

lindsayw@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[lindsayw, 2017-05-18 19:05:54]

Thanks for the review!

[lindsayw, 2017-05-25 14:57:03]

lindsayw@chromium.org changed reviewers:
+ rohitrao@chromium.org
- stkhapugin@chromium.org

[lindsayw, 2017-05-25 14:57:04]

Hi Rohit,
Can you please review since Paris is out and you are owner?
Thanks!

[lindsayw, 2017-05-30 11:54:16]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/static_content:static_content to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/static_content:static_content to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

[lindsayw, 2017-05-30 11:54:16]

lindsayw@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[stkhapugin, 2017-05-30 13:28:17]

lgtm with comments. Thank you for doing this!

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
File ios/chrome/browser/ui/static_content/static_html_native_content.h (right):

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_native_content.h:58:
@property(nonatomic, weak)
This should be strong, because _overscrollActionsController is a strong ivar
(and was backed by scoped_nsobject).

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
File ios/chrome/browser/ui/static_content/static_html_view_controller.mm
(right):

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_view_controller.mm:81: __weak
id<CRWNativeContentDelegate> delegate_;  // weak
remove "// weak" comment

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_view_controller.mm:84: __weak
id<UrlLoader> loader_;  // weak
remove "// weak" comment

[rohitrao (ping after 24h), 2017-05-30 15:00:49]

lg, but waiting for stk's comments to be addressed.

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
File ios/chrome/browser/ui/static_content/static_html_view_controller.h (right):

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_view_controller.h:53:
@property(weak, nonatomic, readonly) WKWebView* webView;
Put the weak attribute last, since that's where we usually put it?

[lindsayw, 2017-06-01 16:02:09]

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
File ios/chrome/browser/ui/static_content/static_html_native_content.h (right):

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_native_content.h:58:
@property(nonatomic, weak)
On 2017/05/30 13:28:16, stkhapugin wrote:
> This should be strong, because _overscrollActionsController is a strong ivar
> (and was backed by scoped_nsobject).

Done.

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
File ios/chrome/browser/ui/static_content/static_html_view_controller.h (right):

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_view_controller.h:53:
@property(weak, nonatomic, readonly) WKWebView* webView;
On 2017/05/30 15:00:49, rohitrao (ping after 24h) wrote:
> Put the weak attribute last, since that's where we usually put it?

Done.

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
File ios/chrome/browser/ui/static_content/static_html_view_controller.mm
(right):

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_view_controller.mm:81: __weak
id<CRWNativeContentDelegate> delegate_;  // weak
On 2017/05/30 13:28:16, stkhapugin wrote:
> remove "// weak" comment

Done.

https://codereview.chromium.org/2890163003/diff/1/ios/chrome/browser/ui/stati...
ios/chrome/browser/ui/static_content/static_html_view_controller.mm:84: __weak
id<UrlLoader> loader_;  // weak
On 2017/05/30 13:28:16, stkhapugin wrote:
> remove "// weak" comment

Done.

[lindsayw, 2017-06-01 16:03:14]

The CQ bit was checked by lindsayw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 16:03:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 17:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 17:26:20]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-06-01 17:26:59]

lgtm

[lindsayw, 2017-06-01 17:29:45]

The CQ bit was checked by lindsayw@chromium.org

[lindsayw, 2017-06-01 17:29:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2890163003/#ps20001
(title: "Addressed all comments.")

[commit-bot: I haz the power, 2017-06-01 17:30:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 17:35:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496338185680610,
"parent_rev": "862a0c176b2b191cee78bd82db01bf6531d299ba", "commit_rev":
"874f0e98a9fa5bcb368ae3582232d0e5506bcc54"}

[commit-bot: I haz the power, 2017-06-01 17:35:12]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/static_content:static_content to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/static_content:static_content to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2890163003
Cr-Commit-Position: refs/heads/master@{#476340}
Committed:
https://chromium.googlesource.com/chromium/src/+/874f0e98a9fa5bcb368ae3582232...
==========

[commit-bot: I haz the power, 2017-06-01 17:35:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/874f0e98a9fa5bcb368ae3582232...