Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(247)

Issue 2890143002: Set 'whitespace_removed' correctly when resolving relative URLs. (Closed)

Created:
11 months, 1 week ago by Mike West
Modified:
11 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set 'whitespace_removed' correctly when resolving relative URLs. The previous two (!!!) patches missed the relative URL resolution path through KURL and url_utils. This patch pokes at the logic one more time. BUG=680970 Review-Url: https://codereview.chromium.org/2890143002 Cr-Commit-Position: refs/heads/master@{#472812} Committed: https://chromium.googlesource.com/chromium/src/+/c9d6c1bb4234256176f66cc8c61c9878c931950a

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/loader/url-strip-cr-lf-tab-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURLTest.cpp View 2 chunks +29 lines, -1 line 0 comments Download
M url/url_canon_relative.cc View 1 chunk +6 lines, -1 line 0 comments Download
M url/url_util_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Mike West
WDYT, Jochen?
11 months, 1 week ago (2017-05-18 10:09:35 UTC) #4
jochen (gone - plz use gerrit)
lgtm
11 months, 1 week ago (2017-05-18 11:18:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890143002/20001
11 months, 1 week ago (2017-05-18 12:22:35 UTC) #10
commit-bot: I haz the power
11 months ago (2017-05-18 15:05:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9d6c1bb4234256176f66cc8c61c...

Powered by Google App Engine
This is Rietveld 408576698