Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2890143002: Set 'whitespace_removed' correctly when resolving relative URLs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 5 hours ago by Mike West
Modified:
4 days ago
Reviewers:
jochen
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set 'whitespace_removed' correctly when resolving relative URLs. The previous two (!!!) patches missed the relative URL resolution path through KURL and url_utils. This patch pokes at the logic one more time. BUG=680970 Review-Url: https://codereview.chromium.org/2890143002 Cr-Commit-Position: refs/heads/master@{#472812} Committed: https://chromium.googlesource.com/chromium/src/+/c9d6c1bb4234256176f66cc8c61c9878c931950a

Patch Set 1 #

Patch Set 2 : Test. #

Messages

Total messages: 13 (9 generated)
Mike West
WDYT, Jochen?
4 days, 5 hours ago (2017-05-18 10:09:35 UTC) #4
jochen
lgtm
4 days, 4 hours ago (2017-05-18 11:18:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890143002/20001
4 days, 3 hours ago (2017-05-18 12:22:35 UTC) #10
commit-bot: I haz the power
4 days ago (2017-05-18 15:05:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9d6c1bb4234256176f66cc8c61c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06