[Chromedriver] Allow access to chrome extension within iframe.

[Chromedriver] Allow access to chrome extension within iframe.

BUG=chromedriver:1777
Review-Url: https://codereview.chromium.org/2890103002
Cr-Commit-Position: refs/heads/master@{#473327}
Committed: https://chromium.googlesource.com/chromium/src/+/566594d722eb79ac2fb245bb8493763dd170f076

[gmanikpure, 2017-05-17 23:53:58]

gmanikpure@chromium.org changed reviewers:
+ johnchen@chromium.org

[gmanikpure, 2017-05-17 23:53:59]

Hi John,

This CL fixes https://bugs.chromium.org/p/chromedriver/issues/detail?id=1777 .
Due to crrev.com/450821, iframe having chrome extension is not detected as frame
by Chromedriver in Chrome58+.

I have scheduled global presubmit
https://critique.corp.google.com/#review/156365475 to make sure there are no
regressions in google3. Will update the status here once it is completed.

Thanks,
Gauri

[johnchen, 2017-05-18 14:02:44]

lgtm

[gmanikpure, 2017-05-18 21:46:36]

gmanikpure@chromium.org changed reviewers:
+ stgao@chromium.org

[gmanikpure, 2017-05-18 21:46:36]

Thanks John,

Global presubmit looks good.
https://test.corp.google.com/ui#cl=156365475
No regressions found.

I am planning to use a packed extension in order to have unique id across
various machines. Please take a look at the second patch. Thanks!

[johnchen, 2017-05-19 14:51:51]

lgtm

[gmanikpure, 2017-05-19 16:37:08]

Thanks John!

Hi Shuotao,

CL needs your approval. Could you please take a look?

Thanks,
Gauri

[stgao, 2017-05-19 19:59:03]

code style lgtm

[gmanikpure, 2017-05-19 20:00:32]

The CQ bit was checked by gmanikpure@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:02:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:30:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495224032180790,
"parent_rev": "107bc42153f7df4157a1beea973ca03bd34404d8", "commit_rev":
"566594d722eb79ac2fb245bb8493763dd170f076"}

[commit-bot: I haz the power, 2017-05-19 21:30:49]

Description was changed from

==========
[Chromedriver] Allow access to chrome extension within iframe.

BUG=chromedriver:1777
==========

to

==========
[Chromedriver] Allow access to chrome extension within iframe.

BUG=chromedriver:1777

Review-Url: https://codereview.chromium.org/2890103002
Cr-Commit-Position: refs/heads/master@{#473327}
Committed:
https://chromium.googlesource.com/chromium/src/+/566594d722eb79ac2fb245bb8493...
==========

[commit-bot: I haz the power, 2017-05-19 21:30:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/566594d722eb79ac2fb245bb8493...