Chromium Code Reviews| Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h |
| diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h |
| index 51a04b8762af809f5b5d1649ce8f2691a55b7f6f..2285f697b08b5c1520397efd1333b046b7f14e09 100644 |
| --- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h |
| +++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h |
| @@ -254,6 +254,9 @@ class DataReductionProxyConfig |
| FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, |
| LoFiAccuracyNonZeroDelay); |
| FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, WarmupURL); |
| + FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, |
| + ShouldAcceptServerLoFi); |
| + FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, ShouldAcceptLitePages); |
| // Values of the estimated network quality at the beginning of the most |
| // recent query of the Network Quality Estimator. |
| @@ -300,11 +303,28 @@ class DataReductionProxyConfig |
| bool is_https, |
| base::TimeDelta* min_retry_delay) const; |
| + // Returns whether the client should report to the data reduction proxy that |
| + // it is will to accept the Server Lo-Fi optimization for |request|. |
|
bengr
2017/05/19 20:20:47
will -> willing
dougarnett
2017/05/19 21:43:58
Done.
|
| + // |previews_decider| is a non-null object that determines eligibility of the |
|
bengr
2017/05/19 20:20:47
I can't parse this sentence.
dougarnett
2017/05/19 21:43:58
Yeah, not my wording, I lifted this exact wording
dougarnett
2017/05/19 22:41:22
Tried to clarify this wording now.
|
| + // showing the preview based on past opt outs. |
| + // Should only be used if kDataReductionProxyDecidesTransform feature enabled. |
|
bengr
2017/05/19 20:20:47
feature -> feature is
dougarnett
2017/05/19 21:43:58
Done.
|
| + bool ShouldAcceptServerLoFi(const net::URLRequest& request, |
| + previews::PreviewsDecider* previews_decider); |
| + |
| + // Returns whether the client should report to the data reduction proxy that |
| + // it is will to accept a LitePage optimization for |request|. |
|
bengr
2017/05/19 20:20:47
will -> willing
dougarnett
2017/05/19 21:43:58
Done.
|
| + // |previews_decider| is a non-null object that determines eligibility of the |
|
bengr
2017/05/19 20:20:47
I can't parse.
dougarnett
2017/05/19 21:43:58
ditto
|
| + // showing the preview based on past opt outs. |
| + // Should only be used if kDataReductionProxyDecidesTransform feature enabled. |
|
bengr
2017/05/19 20:20:47
feature -> feature is
dougarnett
2017/05/19 21:43:58
Done.
|
| + bool ShouldAcceptLitePages(const net::URLRequest& request, |
| + previews::PreviewsDecider* previews_decider); |
| + |
| // Returns true when Lo-Fi Previews should be activated. Determines if Lo-Fi |
| // Previews should be activated by checking the Lo-Fi flags and if the network |
| // quality is prohibitively slow. |network_quality_estimator| may be NULL. |
| // |previews_decider| is a non-null object that determines eligibility of the |
| // showing the preview based on past opt outs. |
| + // Should NOT be used if kDataReductionProxyDecidesTransform feature enabled. |
|
bengr
2017/05/19 20:20:47
if -> if the
feature -> feature is
dougarnett
2017/05/19 21:43:58
Done.
|
| bool ShouldEnableLoFiInternal(const net::URLRequest& request, |
| previews::PreviewsDecider* previews_decider); |
| @@ -314,6 +334,7 @@ class DataReductionProxyConfig |
| // |network_quality_estimator| may be NULL. |previews_decider| is a non-null |
| // object that determines eligibility of showing the preview based on past opt |
| // outs. |
| + // Should NOT be used if kDataReductionProxyDecidesTransform feature enabled. |
|
bengr
2017/05/19 20:20:47
Add 'the' and 'is'
dougarnett
2017/05/19 21:43:58
Done.
|
| bool ShouldEnableLitePagesInternal( |
| const net::URLRequest& request, |
| previews::PreviewsDecider* previews_decider); |