New CPAT support in DataReductionProxyConfig guarded by feature flag.

components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_CONFIG_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_CONFIG_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 236 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
                            AreProxiesBypassedRetryDelay);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, AutoLoFiParams);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, AutoLoFiMissingParams);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
                            AutoLoFiParamsSlowConnectionsFlag);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, LoFiAccuracy);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
                            LoFiAccuracyNonZeroDelay);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, WarmupURL);
+  FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest,
+                           ShouldAcceptServerLoFi);
+  FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, ShouldAcceptLitePages);
 
   // Values of the estimated network quality at the beginning of the most
   // recent query of the Network Quality Estimator.
   enum NetworkQualityAtLastQuery {
     NETWORK_QUALITY_AT_LAST_QUERY_UNKNOWN,
     NETWORK_QUALITY_AT_LAST_QUERY_SLOW,
     NETWORK_QUALITY_AT_LAST_QUERY_NOT_SLOW
   };
 
   // NetworkChangeNotifier::IPAddressObserver:
@@ skipping 26 matching lines @@
   // proxies are bypassed, returns the minimum retry delay of the bypassed data
   // reduction proxies in min_retry_delay (if not NULL). If there are no
   // bypassed data reduction proxies for the request scheme, returns false and
   // does not assign min_retry_delay.
   bool AreProxiesBypassed(
       const net::ProxyRetryInfoMap& retry_map,
       const net::ProxyConfig::ProxyRules& proxy_rules,
       bool is_https,
       base::TimeDelta* min_retry_delay) const;
 
+  // Returns whether the client should report to the data reduction proxy that
+  // it is will to accept the Server Lo-Fi optimization for |request|.

[bengr, 2017/05/19 20:20:47]

will -> willing

[dougarnett, 2017/05/19 21:43:58]

Done.

+  // |previews_decider| is a non-null object that determines eligibility of the

[bengr, 2017/05/19 20:20:47]

I can't parse this sentence.

[dougarnett, 2017/05/19 21:43:58]

Yeah, not my wording, I lifted this exact wording from
ShouldEnableLoFiInternal() to keep consistent (since outside scope of what I am
meaning to change here).

[dougarnett, 2017/05/19 22:41:22]

Tried to clarify this wording now.

+  // showing the preview based on past opt outs.
+  // Should only be used if kDataReductionProxyDecidesTransform feature enabled.

[bengr, 2017/05/19 20:20:47]

feature -> feature is

[dougarnett, 2017/05/19 21:43:58]

Done.

+  bool ShouldAcceptServerLoFi(const net::URLRequest& request,
+                              previews::PreviewsDecider* previews_decider);
+
+  // Returns whether the client should report to the data reduction proxy that
+  // it is will to accept a LitePage optimization for |request|.

[bengr, 2017/05/19 20:20:47]

will -> willing

[dougarnett, 2017/05/19 21:43:58]

Done.

+  // |previews_decider| is a non-null object that determines eligibility of the

[bengr, 2017/05/19 20:20:47]

I can't parse.

[dougarnett, 2017/05/19 21:43:58]

ditto

+  // showing the preview based on past opt outs.
+  // Should only be used if kDataReductionProxyDecidesTransform feature enabled.

[bengr, 2017/05/19 20:20:47]

feature -> feature is

[dougarnett, 2017/05/19 21:43:58]

Done.

+  bool ShouldAcceptLitePages(const net::URLRequest& request,
+                             previews::PreviewsDecider* previews_decider);
+
   // Returns true when Lo-Fi Previews should be activated. Determines if Lo-Fi
   // Previews should be activated by checking the Lo-Fi flags and if the network
   // quality is prohibitively slow. |network_quality_estimator| may be NULL.
   // |previews_decider| is a non-null object that determines eligibility of the
   // showing the preview based on past opt outs.
+  // Should NOT be used if kDataReductionProxyDecidesTransform feature enabled.

[bengr, 2017/05/19 20:20:47]

if -> if the
feature -> feature is

[dougarnett, 2017/05/19 21:43:58]

Done.

   bool ShouldEnableLoFiInternal(const net::URLRequest& request,
                                 previews::PreviewsDecider* previews_decider);
 
   // Returns true when Lite Page Previews should be activated. Determines if
   // Lite Page Previewsmode should be activated by checking the Lite Page
   // Previews flags and if the network quality is prohibitively slow.
   // |network_quality_estimator| may be NULL. |previews_decider| is a non-null
   // object that determines eligibility of showing the preview based on past opt
   // outs.
+  // Should NOT be used if kDataReductionProxyDecidesTransform feature enabled.

[bengr, 2017/05/19 20:20:47]

Add 'the' and 'is'

[dougarnett, 2017/05/19 21:43:58]

Done.

   bool ShouldEnableLitePagesInternal(
       const net::URLRequest& request,
       previews::PreviewsDecider* previews_decider);
 
   // Returns true if the network quality is at least as poor as the one
   // specified in the Auto Lo-Fi field trial parameters.
   // |network_quality_estimator| may be NULL. Virtualized for unit testing.
   virtual bool IsNetworkQualityProhibitivelySlow(
       const net::NetworkQualityEstimator* network_quality_estimator);
 
@@ skipping 109 matching lines @@
   bool is_captive_portal_;
 
   base::WeakPtrFactory<DataReductionProxyConfig> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyConfig);
 };
 
 }  // namespace data_reduction_proxy
 
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_CONFIG_H_