Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2889993002: [ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:unit_tests to ARC. (Closed)

Created:
3 years, 7 months ago by stkhapugin
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/contextual_search:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2889993002 Cr-Commit-Position: refs/heads/master@{#472561} Committed: https://chromium.googlesource.com/chromium/src/+/07d11ddc07d70c0b5219c5b90a4138770450c9d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -41 lines) Patch
M ios/chrome/browser/ui/contextual_search/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_js_unittest.mm View 4 chunks +12 lines, -10 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator_unittest.mm View 12 chunks +29 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
stkhapugin
PTAL
3 years, 7 months ago (2017-05-17 15:36:50 UTC) #4
sdefresne
lgtm
3 years, 7 months ago (2017-05-17 15:51:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889993002/1
3 years, 7 months ago (2017-05-17 16:04:40 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 20:58:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07d11ddc07d70c0b5219c5b90a41...

Powered by Google App Engine
This is Rietveld 408576698