Make EnabledRangeInRichlyEditableText return false for user-triggered command and unfocused selecti…

Make EnabledRangeInRichlyEditableText return false for user-triggered command and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Unlink command.

BUG=722925
TEST=editing/execCommand/unlink_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2889963003
Cr-Commit-Position: refs/heads/master@{#472696}
Committed: https://chromium.googlesource.com/chromium/src/+/b2dde8c244c58dcf6d38d812ca064f911b1b0fe6

[Xiaocheng, 2017-05-17 20:35:00]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:36:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 23:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:29:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2017-05-17 23:53:23]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:54:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-18 00:09:09]

Description was changed from

==========
Make EnabledRangeInRichlyEditableText return false for user-triggered command
and unfocused selection

BUG=
==========

to

==========
Make EnabledRangeInRichlyEditableText return false for user-triggered command
and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Unlink command.

BUG=722925
TEST=editing/execCommand/unlink_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-18 00:09:16]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-18 00:09:17]

PTAL.

[yosin_UTC9, 2017-05-18 00:57:14]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 00:57:16]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 00:57:17]

lgtm

[commit-bot: I haz the power, 2017-05-18 00:58:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 06:04:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495069036679340, "parent_rev":
"27355196d32f75606b3e43b54bd0d03ef42b4579", "commit_rev":
"b2dde8c244c58dcf6d38d812ca064f911b1b0fe6"}

[commit-bot: I haz the power, 2017-05-18 06:04:54]

Description was changed from

==========
Make EnabledRangeInRichlyEditableText return false for user-triggered command
and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Unlink command.

BUG=722925
TEST=editing/execCommand/unlink_with_unfocused_selection.html
==========

to

==========
Make EnabledRangeInRichlyEditableText return false for user-triggered command
and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Unlink command.

BUG=722925
TEST=editing/execCommand/unlink_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2889963003
Cr-Commit-Position: refs/heads/master@{#472696}
Committed:
https://chromium.googlesource.com/chromium/src/+/b2dde8c244c58dcf6d38d812ca06...
==========

[commit-bot: I haz the power, 2017-05-18 06:04:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2dde8c244c58dcf6d38d812ca06...