Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2889903002: Remove usage of RefPtr::Release() passed to ComputedStyle setters. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of RefPtr::Release() passed to ComputedStyle setters. In a follow up patch [1], we remove the use of PassRefPtr in several ComputedStyle setters by replacing them with RefPtr. However, this means that callers which use RefPtr::Release to convert a RefPtr into a PassRefPtr in order to pass it to one of those setters no longer make sense. This patch simply goes through the callers of these setters and replaces any RefPtr::Release with std::move to bypass the usage of PassRefPtrs entirely. [1] https://codereview.chromium.org/2881143004 BUG=494719 Review-Url: https://codereview.chromium.org/2889903002 Cr-Commit-Position: refs/heads/master@{#472675} Committed: https://chromium.googlesource.com/chromium/src/+/01bbf1a419789e2f031e00b60f62a2de92e9feb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
shend
Hi Bugs, PTAL
3 years, 7 months ago (2017-05-17 06:12:01 UTC) #4
Bugs Nash
lgtm
3 years, 7 months ago (2017-05-17 22:59:24 UTC) #8
shend
Hi yutak, PTAL
3 years, 7 months ago (2017-05-17 23:52:53 UTC) #10
Yuta Kitamura
lgtm
3 years, 7 months ago (2017-05-18 04:57:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889903002/1
3 years, 7 months ago (2017-05-18 04:59:05 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 05:07:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01bbf1a419789e2f031e00b60f62...

Powered by Google App Engine
This is Rietveld 408576698