md settings: Fix dialog buttons on lock screen.

md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock screen. They dont use the 'button-container' class from cr-dialog, so they are missing some margins/paddings the other dialogs have. Also the previous 'button-strip' was part of the body content of cr-dialog.

Before: https://screenshot.googleplex.com/heBMZLNjZXY
After: https://screenshot.googleplex.com/TYHdxUQNzC6

TEST=manual
BUG=723192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889893002
Cr-Commit-Position: refs/heads/master@{#472586}
Committed: https://chromium.googlesource.com/chromium/src/+/e1d96eb7bec272c948773c33474bbcc5479c5503

[sammiequon, 2017-05-17 01:29:06]

Description was changed from

==========
md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock
screen. They dont use the 'button-container' class from cr-dialog, so they are
missing some margins/paddings the other dialogs have.

TEST=manual
BUG=723192
==========

to

==========
md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock
screen. They dont use the 'button-container' class from cr-dialog, so they are
missing some margins/paddings the other dialogs have.

TEST=manual
BUG=723192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-05-17 01:31:05]

Description was changed from

==========
md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock
screen. They dont use the 'button-container' class from cr-dialog, so they are
missing some margins/paddings the other dialogs have.

TEST=manual
BUG=723192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock
screen. They dont use the 'button-container' class from cr-dialog, so they are
missing some margins/paddings the other dialogs have. Also the previous
'button-strip' was part of the body content of cr-dialog.

Before: https://screenshot.googleplex.com/heBMZLNjZXY
After: https://screenshot.googleplex.com/TYHdxUQNzC6

TEST=manual
BUG=723192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-05-17 01:31:05]

sammiequon@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sammiequon, 2017-05-17 03:45:28]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 03:46:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:54:52]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sammiequon, 2017-05-17 15:14:15]

stevenjb@ - Please take a look. Thanks!

[stevenjb, 2017-05-17 15:57:37]

lgtm

https://codereview.chromium.org/2889893002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/password_prompt_dialog.html
(right):

https://codereview.chromium.org/2889893002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/password_prompt_dialog.html:42:
passwordInvalid_)]]">
4 character indent for both of these lines (which should then fit on one).

[sammiequon, 2017-05-17 16:37:47]

Thanks!

https://codereview.chromium.org/2889893002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/password_prompt_dialog.html
(right):

https://codereview.chromium.org/2889893002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/password_prompt_dialog.html:42:
passwordInvalid_)]]">
On 2017/05/17 15:57:36, stevenjb wrote:
> 4 character indent for both of these lines (which should then fit on one).
> 

Done.

[sammiequon, 2017-05-17 16:37:53]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 16:38:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 18:57:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sammiequon, 2017-05-17 19:11:35]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2017-05-17 19:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2889893002/#ps20001
(title: "Fixed patch set 1 errors.")

[commit-bot: I haz the power, 2017-05-17 19:12:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 22:18:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495048295877220,
"parent_rev": "b3b1958f43ccd6cbf37a10a4c173b8dbad17cb08", "commit_rev":
"e1d96eb7bec272c948773c33474bbcc5479c5503"}

[commit-bot: I haz the power, 2017-05-17 22:18:57]

Description was changed from

==========
md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock
screen. They dont use the 'button-container' class from cr-dialog, so they are
missing some margins/paddings the other dialogs have. Also the previous
'button-strip' was part of the body content of cr-dialog.

Before: https://screenshot.googleplex.com/heBMZLNjZXY
After: https://screenshot.googleplex.com/TYHdxUQNzC6

TEST=manual
BUG=723192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock
screen. They dont use the 'button-container' class from cr-dialog, so they are
missing some margins/paddings the other dialogs have. Also the previous
'button-strip' was part of the body content of cr-dialog.

Before: https://screenshot.googleplex.com/heBMZLNjZXY
After: https://screenshot.googleplex.com/TYHdxUQNzC6

TEST=manual
BUG=723192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889893002
Cr-Commit-Position: refs/heads/master@{#472586}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1d96eb7bec272c948773c33474b...
==========

[commit-bot: I haz the power, 2017-05-17 22:18:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1d96eb7bec272c948773c33474b...