Enable print as image by default

chrome/common/chrome_features.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_features.h"
 
 #include "base/command_line.h"
 #include "chrome/common/chrome_switches.h"
 #include "extensions/features/features.h"
 #include "ppapi/features/features.h"
@@ skipping 263 matching lines @@
 #if defined(OS_CHROMEOS)
 // The lock screen will be preloaded so it is instantly available when the user
 // locks the Chromebook device.
 const base::Feature kPreloadLockScreen{"PreloadLockScreen",
                                        base::FEATURE_ENABLED_BY_DEFAULT};
 #endif
 
 #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
 // Enables the Print as Image feature in print preview.
 const base::Feature kPrintPdfAsImage{"PrintPdfAsImage",
-                                     base::FEATURE_DISABLED_BY_DEFAULT};
+                                     base::FEATURE_ENABLED_BY_DEFAULT};

[dpapad, 2017/05/17 16:35:58]

Isn't this enabling by default the feature on all platforms, not just ChromeOS
and Linux? Just checking whether this is intentional, since the CL description
only mentions ChromeOS and Linux.

[rbpotter, 2017/05/17 16:55:09]

Good catch, thanks. Thought I had if defs around this to remove it for
Mac and Win, but apparently not. Added them in new patchset.

 #endif
 
 // Enables or disables push subscriptions keeping Chrome running in the
 // background when closed.
 const base::Feature kPushMessagingBackgroundMode{
     "PushMessagingBackgroundMode", base::FEATURE_DISABLED_BY_DEFAULT};
 
 #if defined(OS_CHROMEOS)
 // Runtime flag that indicates whether this leak detector should be enabled in
 // the current instance of Chrome.
@@ skipping 72 matching lines @@
   return base::FeatureList::IsEnabled(features::kPrefService) ||
 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
          base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
              switches::kMusConfig) == switches::kMash;
 #else
          false;
 #endif
 }
 
 }  // namespace features