Enable print as image by default

chrome/test/data/webui/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 GEN('#include "base/feature_list.h"');
 GEN('#include "chrome/common/chrome_features.h"');
 
 /**
  * Test fixture for print preview WebUI testing.
  * @constructor
@@ skipping 41 matching lines @@
   /** @override */
   runAccessibilityChecks: true,
 
   /** @override */
   accessibilityIssuesAreErrors: true,
 
   /** @override */
   isAsync: true,
 
   /**
-   * @override
-   */
-  testGenPreamble: function() {
-    // Enable print as image for tests on non Windows/Mac.
-    GEN('#if !defined(OS_WINDOWS) && !defined(OS_MACOSX)');
-    GEN('  base::FeatureList::ClearInstanceForTesting();');
-    GEN('  std::unique_ptr<base::FeatureList>');
-    GEN('      feature_list(new base::FeatureList);');
-    GEN('  feature_list->InitializeFromCommandLine(');
-    GEN('      features::kPrintPdfAsImage.name, std::string());');
-    GEN('  base::FeatureList::SetInstance(std::move(feature_list));');
-    GEN('#endif');
-  },
-
-  /**
    * Stub out low-level functionality like the NativeLayer and
    * CloudPrintInterface.
    * @this {PrintPreviewWebUITest}
    * @override
    */
   preLoad: function() {
     window.addEventListener('DOMContentLoaded', function() {
       function NativeLayerStub() {
         cr.EventTarget.call(this);
         this.printStarted_ = false;
@@ skipping 327 matching lines @@
               is_default: true
             }
           ]
         }
       }
     }
   };
 }
 
 function isPrintAsImageEnabled() {
-  return !cr.isWindows && !cr.isMac;
+  // Should be enabled by default on non Windows/Mac
+  return (!cr.isWindows && !cr.isMac &&
+          loadTimeData.getBoolean('printPdfAsImageEnabled'));
 }
 
 // Test restore settings with one destination.
 TEST_F('PrintPreviewWebUITest', 'TestPrintPreviewRestoreLocalDestination',
     function() {
   this.initialSettings_.serializedAppStateStr_ =
       '{"version":2,"recentDestinations":[{"id":"ID", "origin":"local",' +
         '"account":"", "capabilities":0, "name":"", "extensionId":"",' +
             '"extensionName":""}]}';
   this.setInitialSettings();
@@ skipping 49 matching lines @@
   this.setCapabilities(getCddTemplate('ID3'));
   this.setCapabilities(getCddTemplate('ID4'));
 
   // The most recently used destination should be the currently selected one.
   // This is ID1.
   assertEquals(
       'ID1', printPreview.destinationStore_.selectedDestination.id);
 
   // Look through the destinations. ID1, ID2, and ID3 should all be recent.
   var destinations = printPreview.destinationStore_.destinations_;
-  var ids_found = [];
+  var idsFound = [];
 
   for (var i = 0; i < destinations.length; i++) {
     if (!destinations[i])
       continue;
     if (destinations[i].isRecent)
-      ids_found.push(destinations[i].id);
+      idsFound.push(destinations[i].id);
   }
 
   // Make sure there were 3 recent destinations and that they are the correct
   // IDs.
-  assertEquals(3, ids_found.length);
-  assertNotEquals(-1, ids_found.indexOf("ID1"));
-  assertNotEquals(-1, ids_found.indexOf("ID2"));
-  assertNotEquals(-1, ids_found.indexOf("ID3"));
+  assertEquals(3, idsFound.length);
+  assertNotEquals(-1, idsFound.indexOf("ID1"));
+  assertNotEquals(-1, idsFound.indexOf("ID2"));
+  assertNotEquals(-1, idsFound.indexOf("ID3"));
 
   testDone();
 });
 
 TEST_F('PrintPreviewWebUITest',
     'TestPrintPreviewDefaultDestinationSelectionRules', function() {
   // It also makes sure these rules do override system default destination.
   this.initialSettings_.serializedDefaultDestinationSelectionRulesStr_ =
       '{"namePattern":".*Bar.*"}';
   this.setInitialSettings();
@@ skipping 966 matching lines @@
   printPreview.printTicketStore_.pageRange.updateValue("2");
   expectFalse(this.generateDraft());
 
   // Change the margin type - need to regenerate again.
   printPreview.printTicketStore_.marginsType.updateValue(
       print_preview.ticket_items.MarginsTypeValue.NO_MARGINS);
   expectTrue(this.generateDraft());
 
   testDone();
 });