Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 288983007: aw: Fix hardware init/tear down in pop up flow (Closed)

Created:
6 years, 7 months ago by boliu
Modified:
6 years, 7 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

aw: Fix hardware init/tear down in pop up flow Previously we did not call onDetached on old native AwContents, which now no longer cleans up hardware resources correctly. This also had the side effect that the following onAttach with the new native AwContents is ignored in java code due to attach/detach mismatch. As make onDetached more strict with respect to ordering. And lock to protect variable accessed on multiple threads. Also need to ensure we never requestDrawGL on the blank native AwContents that's destroyed during pop up. BUG=376622 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272500

Patch Set 1 #

Patch Set 2 : more fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -78 lines) Patch
M android_webview/browser/gl_view_renderer_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M android_webview/browser/gl_view_renderer_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/browser/shared_renderer_state.h View 1 3 chunks +5 lines, -8 lines 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 1 2 chunks +5 lines, -17 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +5 lines, -4 lines 0 comments Download
M android_webview/native/aw_contents.h View 2 chunks +1 line, -2 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 3 chunks +45 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
boliu
I'll leave the state in the internal bug
6 years, 7 months ago (2014-05-23 02:51:42 UTC) #1
boliu
Actually figured out our problem, and did a fix without involving frameworks change. I'll update ...
6 years, 7 months ago (2014-05-23 03:09:52 UTC) #2
benm (inactive)
lgtm
6 years, 7 months ago (2014-05-23 09:36:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/288983007/20001
6 years, 7 months ago (2014-05-23 09:37:19 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:55:50 UTC) #5
Message was sent while issue was closed.
Change committed as 272500

Powered by Google App Engine
This is Rietveld 408576698