Only skip uploading of addin if the file already exists on google storage.

visual_studio/NativeClientVSAddIn/buildbot_run.py

Index: visual_studio/NativeClientVSAddIn/buildbot_run.py
diff --git a/visual_studio/NativeClientVSAddIn/buildbot_run.py b/visual_studio/NativeClientVSAddIn/buildbot_run.py
index bc786a30e8b94a7dfed8fe1382082789b76dc744..7fd742da4da6074aaf5d6b93d4d55451690fa694 100755
--- a/visual_studio/NativeClientVSAddIn/buildbot_run.py
+++ b/visual_studio/NativeClientVSAddIn/buildbot_run.py
@@ -159,16 +159,6 @@ def _GetGsutil():
 
 
 def StepArchive(revision):
-  # The BUILDBOT_REVISION environment variable gets set to the revsion that
-  # triggered a given build.  For periodic schedulers this will be an empty
-  # string since they are not triggered by a particular revision.  We don't
-  # want to upload the build results to google storage for periodic schedulers
-  # so we skip this step in that case.
-  triggered_revision = os.environ.get('BUILDBOT_REVISION')
-  if triggered_revision == '' or triggered_revision is None:
-    Log('Skipping archive step: BUILDBOT_REVISION not set')
-    return
-
   Log('@@@BUILD_STEP archive build [r%s]@@@' % revision)
   basename = 'vs_addin.tgz'
   remote_name = '%s/%s/%s' % (GSPATH, revision, basename)
@@ -179,8 +169,7 @@ def StepArchive(revision):
 
   # Check for existing file on google storage
   if RunCommand(gsutil + ['ls', gs_remote_name], check_return_code=False) == 0:
-    Log('File already exists on google storage: %s' % gs_remote_name)
-    Log('@@@STEP_FAILURE@@@')
+    Log('Skipping archive step: file already exists on google storage')
     sys.exit(1)

[binji, 2014/06/14 01:13:37]

just return? Or sys.exit(0)?

[Sam Clegg, 2014/06/17 21:23:54]

Done.

 
   # Upload to google storage