Issue 288983005: Only skip uploading of addin if the file already exists on google storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 288983005: Only skip uploading of addin if the file already exists on google storage. (Closed)

Created:
6 years, 7 months ago by Sam Clegg

Modified:
6 years, 6 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Only skip uploading of addin if the file already exists on google storage. The means the periodic builder can upload a revision if the main builder happened flake and not upload first. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1574

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/buildbot_run.py	View	1	2 chunks	+2 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/288983005/diff/1/visual_studio/NativeClientVSAddIn/buildbot_run.py File visual_studio/NativeClientVSAddIn/buildbot_run.py (right): https://codereview.chromium.org/288983005/diff/1/visual_studio/NativeClientVSAddIn/buildbot_run.py#newcode173 visual_studio/NativeClientVSAddIn/buildbot_run.py:173: sys.exit(1) just return? Or sys.exit(0)?

6 years, 6 months ago (2014-06-14 01:13:37 UTC) #2

Sam Clegg

https://codereview.chromium.org/288983005/diff/1/visual_studio/NativeClientVSAddIn/buildbot_run.py File visual_studio/NativeClientVSAddIn/buildbot_run.py (right): https://codereview.chromium.org/288983005/diff/1/visual_studio/NativeClientVSAddIn/buildbot_run.py#newcode173 visual_studio/NativeClientVSAddIn/buildbot_run.py:173: sys.exit(1) On 2014/06/14 01:13:37, binji wrote: > just return? ...

6 years, 6 months ago (2014-06-17 21:23:54 UTC) #3

Sam Clegg

6 years, 6 months ago (2014-06-17 21:24:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r1574 (presubmit successful).

Expand Messages | Collapse Messages