Add tests for certificates that pass X509CertificateBytes parsing, but fail in CertVerifyProc. Fix …

Add tests for certificates that pass X509CertificateBytes parsing, but fail in CertVerifyProc. Fix iOS.

BUG=711077, 671420
Review-Url: https://codereview.chromium.org/2889813002
Cr-Commit-Position: refs/heads/master@{#472277}
Committed: https://chromium.googlesource.com/chromium/src/+/aef2f1c86c8ee6849816ad81443a04148d295784

[mattm, 2017-05-16 22:43:13]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 22:45:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-05-16 22:46:25]

mattm@chromium.org changed reviewers:
+ eroman@chromium.org

[mattm, 2017-05-16 22:46:26]

https://codereview.chromium.org/2889813002/diff/1/net/cert/cert_verify_proc_i...
File net/cert/cert_verify_proc_ios.cc (right):

https://codereview.chromium.org/2889813002/diff/1/net/cert/cert_verify_proc_i...
net/cert/cert_verify_proc_ios.cc:260: if (!cert_array) {
</shamecube>

https://codereview.chromium.org/2889813002/diff/1/net/cert/cert_verify_proc_m...
File net/cert/cert_verify_proc_mac.cc (right):

https://codereview.chromium.org/2889813002/diff/1/net/cert/cert_verify_proc_m...
net/cert/cert_verify_proc_mac.cc:746: verify_result->cert_status |=
CERT_STATUS_INVALID;
note: Need to set status here or later checks in CertVerifyProc::Verify can
override the return code (eg, common_name check).

[eroman, 2017-05-16 22:53:14]

lgtm

[mattm, 2017-05-17 00:06:05]

The CQ bit was unchecked by mattm@chromium.org

[mattm, 2017-05-17 00:06:06]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:06:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:06:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494979566637150, "parent_rev":
"23a57a1539f1ebf22f42d01a2978ed5b67654201", "commit_rev":
"aef2f1c86c8ee6849816ad81443a04148d295784"}

[commit-bot: I haz the power, 2017-05-17 01:06:33]

Description was changed from

==========
Add tests for certificates that pass X509CertificateBytes parsing, but fail in
CertVerifyProc. Fix iOS.

BUG=711077,671420
==========

to

==========
Add tests for certificates that pass X509CertificateBytes parsing, but fail in
CertVerifyProc. Fix iOS.

BUG=711077,671420

Review-Url: https://codereview.chromium.org/2889813002
Cr-Commit-Position: refs/heads/master@{#472277}
Committed:
https://chromium.googlesource.com/chromium/src/+/aef2f1c86c8ee6849816ad81443a...
==========

[commit-bot: I haz the power, 2017-05-17 01:06:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aef2f1c86c8ee6849816ad81443a...