md settings: Give focus to password prompt on tap.

md settings: Give focus to password prompt on tap.

Previously the password prompt would open on navigation to lock screen page but not focus, if the user used the touch screen and not the mouse. Also fixed a bug with easy unlock turn off dialog only being able to be used once.

TEST=manual
BUG=717581
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889803002
Cr-Commit-Position: refs/heads/master@{#472546}
Committed: https://chromium.googlesource.com/chromium/src/+/a54497f5b8d234513196f991d3748afc6755a2e7

[sammiequon, 2017-05-16 22:24:21]

Description was changed from

==========
md settings: Give focus to password prompt on tap.

Previously the password prompt would open on navigation to lock screen page but
not focus, if the user used the touch screen and not the mouse.

TEST=manual
BUG=717581
==========

to

==========
md settings: Give focus to password prompt on tap.

Previously the password prompt would open on navigation to lock screen page but
not focus, if the user used the touch screen and not the mouse.

TEST=manual
BUG=717581
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-05-16 22:25:52]

Description was changed from

==========
md settings: Give focus to password prompt on tap.

Previously the password prompt would open on navigation to lock screen page but
not focus, if the user used the touch screen and not the mouse.

TEST=manual
BUG=717581
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md settings: Give focus to password prompt on tap.

Previously the password prompt would open on navigation to lock screen page but
not focus, if the user used the touch screen and not the mouse. Also fixed a bug
with easy unlock turn off dialog only being able to be used once.

TEST=manual
BUG=717581
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-05-16 22:25:52]

sammiequon@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sammiequon, 2017-05-16 22:27:39]

stevenjb@ - Please take a look. Thanks!

https://codereview.chromium.org/2889803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/lock_screen.html (left):

https://codereview.chromium.org/2889803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.html:174:
</settings-setup-pin-dialog>
On a separate note/CL should these dialogs be wrapped in dom-if like the easy
unlock one (and some others I came across while debugging).

[stevenjb, 2017-05-16 22:51:10]

lgtm

https://codereview.chromium.org/2889803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/lock_screen.html (left):

https://codereview.chromium.org/2889803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.html:174:
</settings-setup-pin-dialog>
On 2017/05/16 22:27:38, sammiequon wrote:
> On a separate note/CL should these dialogs be wrapped in dom-if like the easy
> unlock one (and some others I came across while debugging).

Yep

[sammiequon, 2017-05-16 23:07:28]

Thanks!

https://codereview.chromium.org/2889803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/lock_screen.html (left):

https://codereview.chromium.org/2889803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.html:174:
</settings-setup-pin-dialog>
On 2017/05/16 22:51:09, stevenjb wrote:
> On 2017/05/16 22:27:38, sammiequon wrote:
> > On a separate note/CL should these dialogs be wrapped in dom-if like the
easy
> > unlock one (and some others I came across while debugging).
> 
> Yep

Got it. Filed a bug.

[sammiequon, 2017-05-16 23:07:40]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:10:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 00:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:48:02]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sammiequon, 2017-05-17 03:43:57]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:45:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:59:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sammiequon, 2017-05-17 18:24:25]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:25:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:51:10]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-05-17 19:59:11]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:00:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:19:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495051151362150, "parent_rev":
"45371c8b1e01bac440bc20f29782ceec2580bbc7", "commit_rev":
"a54497f5b8d234513196f991d3748afc6755a2e7"}

[commit-bot: I haz the power, 2017-05-17 20:19:23]

Description was changed from

==========
md settings: Give focus to password prompt on tap.

Previously the password prompt would open on navigation to lock screen page but
not focus, if the user used the touch screen and not the mouse. Also fixed a bug
with easy unlock turn off dialog only being able to be used once.

TEST=manual
BUG=717581
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md settings: Give focus to password prompt on tap.

Previously the password prompt would open on navigation to lock screen page but
not focus, if the user used the touch screen and not the mouse. Also fixed a bug
with easy unlock turn off dialog only being able to be used once.

TEST=manual
BUG=717581
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889803002
Cr-Commit-Position: refs/heads/master@{#472546}
Committed:
https://chromium.googlesource.com/chromium/src/+/a54497f5b8d234513196f991d374...
==========

[commit-bot: I haz the power, 2017-05-17 20:19:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a54497f5b8d234513196f991d374...