Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2889733002: Set the target lazily for the coalesced events (Closed)

Created:
3 years, 7 months ago by Navid Zolghadr
Modified:
3 years, 7 months ago
Reviewers:
dtapuska, Rick Byers
CC:
chromium-reviews, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-w3ctests_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the target lazily for the coalesced events Set the target for the coalesced events when they are accessed. This will cause properties like offsetX/offsetY to be correctly calculated. BUG=721485 Review-Url: https://codereview.chromium.org/2889733002 Cr-Commit-Position: refs/heads/master@{#474347} Committed: https://chromium.googlesource.com/chromium/src/+/edf6be53834747cea98abe29b96605a0ca3e1dbd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_constructor.html View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.cpp View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Navid Zolghadr
3 years, 7 months ago (2017-05-16 19:02:38 UTC) #4
dtapuska
On 2017/05/16 19:02:38, Navid Zolghadr wrote: lgtm % nit.
3 years, 7 months ago (2017-05-17 02:17:26 UTC) #7
dtapuska
https://codereview.chromium.org/2889733002/diff/1/third_party/WebKit/Source/core/events/MouseEvent.h File third_party/WebKit/Source/core/events/MouseEvent.h (right): https://codereview.chromium.org/2889733002/diff/1/third_party/WebKit/Source/core/events/MouseEvent.h#newcode223 third_party/WebKit/Source/core/events/MouseEvent.h:223: void ReceivedTarget(); this needs override
3 years, 7 months ago (2017-05-17 02:18:26 UTC) #8
Navid Zolghadr
https://codereview.chromium.org/2889733002/diff/1/third_party/WebKit/Source/core/events/MouseEvent.h File third_party/WebKit/Source/core/events/MouseEvent.h (right): https://codereview.chromium.org/2889733002/diff/1/third_party/WebKit/Source/core/events/MouseEvent.h#newcode223 third_party/WebKit/Source/core/events/MouseEvent.h:223: void ReceivedTarget(); On 2017/05/17 02:18:26, dtapuska wrote: > this ...
3 years, 7 months ago (2017-05-17 14:45:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889733002/20001
3 years, 7 months ago (2017-05-17 14:46:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889733002/20001
3 years, 7 months ago (2017-05-24 15:14:23 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 17:51:00 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/edf6be53834747cea98abe29b966...

Powered by Google App Engine
This is Rietveld 408576698