Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2889723005: Revert "More compact string representation on 64 bit." (Closed)

Created:
3 years, 7 months ago by Dmitry Stefantsov
Modified:
3 years, 7 months ago
Reviewers:
erikcorry
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "More compact string representation on 64 bit." This reverts commit 5c8e472c82f8c403b3e628a40ca0be5fbefa7706. TBR=erikcorry@google.com Committed: https://github.com/dart-lang/sdk/commit/e5f93a068f61dbdc44a58dea075e9d19995110e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -245 lines) Patch
M runtime/platform/globals.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/globals.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 9 chunks +25 lines, -25 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 9 chunks +25 lines, -24 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 7 chunks +13 lines, -19 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 7 chunks +13 lines, -24 lines 0 comments Download
M runtime/vm/object.h View 8 chunks +12 lines, -47 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/raw_object.h View 4 chunks +10 lines, -12 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 4 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Dmitry Stefantsov
Committed patchset #1 (id:1) manually as e5f93a068f61dbdc44a58dea075e9d19995110e4 (presubmit successful).
3 years, 7 months ago (2017-05-18 12:23:22 UTC) #2
erikcorry
3 years, 7 months ago (2017-05-18 12:31:48 UTC) #3
Message was sent while issue was closed. 
Thanks, LGTM

Powered by Google App Engine
This is Rietveld 408576698