Landing Recent QUIC changes until Fri May 12 18:23:26 2017 +0000

Landing Recent QUIC changes until Fri May 12 18:23:26 2017 +0000

Update QUIC flags to the state of May 16, 2017

https://codereview.chromium.org/2889693002/

Deprecate FLAGS_quic_reloadable_flag_quic_allow_2_rtt_bbr_startup.

Merge internal change: 155745171

https://codereview.chromium.org/2886843002/

SendAlgorithmTest should set pacing consistently.  Test only.

The SentPacketManager should set "UsingPacing"  for the SendAlgorithm,
depending on the congestion-control type.  Unfortunately, this is
currently only done if the user calls SetFromConfig to set the
congestion-control type.  Setting the SendAlgorithm directly can result
in a having a congestion-control algorithm that is incompatible with
pacing, but also has UsingPacing set to true.

This is a temporary fix, until we fix b/38146609.  Because of that bug,
the rest of the code is a bit inconsistent on where/when pacing gets
set.

Merge internal change: 155528093

https://codereview.chromium.org/2887803002/

Migrate StringPiece::CopyToString to string::assign.

Merge internal change: 155522173

https://codereview.chromium.org/2881423002/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2889713002
Cr-Commit-Position: refs/heads/master@{#472424}
Committed: https://chromium.googlesource.com/chromium/src/+/3283d323c689285398d1ab564258bdb6567fd673

[Victor Vasiliev, 2017-05-16 18:13:19]

Description was changed from

==========
Update QUIC flags to the state of May 16, 2017

https://codereview.chromium.org/2889693002/

Deprecate FLAGS_quic_reloadable_flag_quic_allow_2_rtt_bbr_startup.

Merge internal change: 155745171

https://codereview.chromium.org/2886843002/

SendAlgorithmTest should set pacing consistently.  Test only.

The SentPacketManager should set "UsingPacing"  for the SendAlgorithm,
depending on the congestion-control type.  Unfortunately, this is
currently only done if the user calls SetFromConfig to set the
congestion-control type.  Setting the SendAlgorithm directly can result
in a having a congestion-control algorithm that is incompatible with
pacing, but also has UsingPacing set to true.

This is a temporary fix, until we fix b/38146609.  Because of that bug,
the rest of the code is a bit inconsistent on where/when pacing gets
set.

Merge internal change: 155528093

https://codereview.chromium.org/2887803002/

Migrate StringPiece::CopyToString to string::assign.

Merge internal change: 155522173

https://codereview.chromium.org/2881423002/

R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Fri May 12 18:23:26 2017 +0000

Update QUIC flags to the state of May 16, 2017

https://codereview.chromium.org/2889693002/

Deprecate FLAGS_quic_reloadable_flag_quic_allow_2_rtt_bbr_startup.

Merge internal change: 155745171

https://codereview.chromium.org/2886843002/

SendAlgorithmTest should set pacing consistently.  Test only.

The SentPacketManager should set "UsingPacing"  for the SendAlgorithm,
depending on the congestion-control type.  Unfortunately, this is
currently only done if the user calls SetFromConfig to set the
congestion-control type.  Setting the SendAlgorithm directly can result
in a having a congestion-control algorithm that is incompatible with
pacing, but also has UsingPacing set to true.

This is a temporary fix, until we fix b/38146609.  Because of that bug,
the rest of the code is a bit inconsistent on where/when pacing gets
set.

Merge internal change: 155528093

https://codereview.chromium.org/2887803002/

Migrate StringPiece::CopyToString to string::assign.

Merge internal change: 155522173

https://codereview.chromium.org/2881423002/

R=rch@chromium.org
BUG=
==========

[Ryan Hamilton, 2017-05-16 21:11:41]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-05-16 21:11:42]

lgtm

Wow, small list this week!

[commit-bot: I haz the power, 2017-05-16 21:12:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:15:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:15:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ryan Hamilton, 2017-05-17 03:27:27]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:28:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:08:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Victor Vasiliev (old), 2017-05-17 10:59:26]

The CQ bit was checked by vasilvv@google.com

[commit-bot: I haz the power, 2017-05-17 10:59:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 11:43:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495018766165110, "parent_rev":
"6403f30a37f9ac07a05c4591ad8aabe202c96f05", "commit_rev":
"3283d323c689285398d1ab564258bdb6567fd673"}

[commit-bot: I haz the power, 2017-05-17 11:43:38]

Description was changed from

==========
Landing Recent QUIC changes until Fri May 12 18:23:26 2017 +0000

Update QUIC flags to the state of May 16, 2017

https://codereview.chromium.org/2889693002/

Deprecate FLAGS_quic_reloadable_flag_quic_allow_2_rtt_bbr_startup.

Merge internal change: 155745171

https://codereview.chromium.org/2886843002/

SendAlgorithmTest should set pacing consistently.  Test only.

The SentPacketManager should set "UsingPacing"  for the SendAlgorithm,
depending on the congestion-control type.  Unfortunately, this is
currently only done if the user calls SetFromConfig to set the
congestion-control type.  Setting the SendAlgorithm directly can result
in a having a congestion-control algorithm that is incompatible with
pacing, but also has UsingPacing set to true.

This is a temporary fix, until we fix b/38146609.  Because of that bug,
the rest of the code is a bit inconsistent on where/when pacing gets
set.

Merge internal change: 155528093

https://codereview.chromium.org/2887803002/

Migrate StringPiece::CopyToString to string::assign.

Merge internal change: 155522173

https://codereview.chromium.org/2881423002/

R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Fri May 12 18:23:26 2017 +0000

Update QUIC flags to the state of May 16, 2017

https://codereview.chromium.org/2889693002/

Deprecate FLAGS_quic_reloadable_flag_quic_allow_2_rtt_bbr_startup.

Merge internal change: 155745171

https://codereview.chromium.org/2886843002/

SendAlgorithmTest should set pacing consistently.  Test only.

The SentPacketManager should set "UsingPacing"  for the SendAlgorithm,
depending on the congestion-control type.  Unfortunately, this is
currently only done if the user calls SetFromConfig to set the
congestion-control type.  Setting the SendAlgorithm directly can result
in a having a congestion-control algorithm that is incompatible with
pacing, but also has UsingPacing set to true.

This is a temporary fix, until we fix b/38146609.  Because of that bug,
the rest of the code is a bit inconsistent on where/when pacing gets
set.

Merge internal change: 155528093

https://codereview.chromium.org/2887803002/

Migrate StringPiece::CopyToString to string::assign.

Merge internal change: 155522173

https://codereview.chromium.org/2881423002/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2889713002
Cr-Commit-Position: refs/heads/master@{#472424}
Committed:
https://chromium.googlesource.com/chromium/src/+/3283d323c689285398d1ab564258...
==========

[commit-bot: I haz the power, 2017-05-17 11:43:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3283d323c689285398d1ab564258...