DevTools: fix popover's account for scrollbar size when measuring content

DevTools: fix popover's account for scrollbar size when measuring content

When calculating the size of a popover with SizeBehavior == MeasureContent,
positioning logic accounts for either a vertical scrollbar or a horizontal one,
but not both. This led to cases where GlassPane allocated enough width, but not
enough height for wide content (e.g. hovering over a long string when paused).

This CL adjusts the constrained popover width/height for scrollbar size in both
directions.

BUG=722899
Review-Url: https://codereview.chromium.org/2889693008
Cr-Commit-Position: refs/heads/master@{#473499}
Committed: https://chromium.googlesource.com/chromium/src/+/7856682b892241cb9263140c56554880633b8d84

[luoe, 2017-05-18 18:58:39]

Description was changed from

==========
DevTools: fix popover's account for scrollbar size when measuring content

BUG=722899
==========

to

==========
DevTools: fix popover's account for scrollbar size when measuring content

When calculating the size of a popover with SizeBehavior == MeasureContent,
positioning logic accounts for either a vertical scrollbar or a horizontal one,
but not both. This led to cases where GlassPane allocated enough width, but not
enough height for wide content (e.g. hovering over a long string when paused).

This CL adjusts the constrained popover width/height for scrollbar size in both
directions.

BUG=722899
==========

[luoe, 2017-05-18 20:11:48]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, einbinder@chromium.org

[luoe, 2017-05-18 20:11:49]

Please take a look.

While this CL changes positioning, anchor behavior, and size, only popovers
using SizeBehavior == MeasureContent are affected.

Non-exhaustive list of modals I manually tested:
Color/shadow swatches in SSP and Sources
Filepicker/command menu
SettingsScreen
Manage Header Columns in Network
Timeline FilmStripView frames dialog
Add Source Map URL dialog

[dgozman, 2017-05-18 22:02:17]

lgtm

[luoe, 2017-05-21 21:49:11]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-05-21 21:49:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 23:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 23:13:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[luoe, 2017-05-22 02:39:09]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-05-22 02:39:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 03:46:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495420749185840, "parent_rev":
"f1f1920bf691e654157b99c52d13356a645af236", "commit_rev":
"7856682b892241cb9263140c56554880633b8d84"}

[commit-bot: I haz the power, 2017-05-22 03:46:39]

Description was changed from

==========
DevTools: fix popover's account for scrollbar size when measuring content

When calculating the size of a popover with SizeBehavior == MeasureContent,
positioning logic accounts for either a vertical scrollbar or a horizontal one,
but not both. This led to cases where GlassPane allocated enough width, but not
enough height for wide content (e.g. hovering over a long string when paused).

This CL adjusts the constrained popover width/height for scrollbar size in both
directions.

BUG=722899
==========

to

==========
DevTools: fix popover's account for scrollbar size when measuring content

When calculating the size of a popover with SizeBehavior == MeasureContent,
positioning logic accounts for either a vertical scrollbar or a horizontal one,
but not both. This led to cases where GlassPane allocated enough width, but not
enough height for wide content (e.g. hovering over a long string when paused).

This CL adjusts the constrained popover width/height for scrollbar size in both
directions.

BUG=722899

Review-Url: https://codereview.chromium.org/2889693008
Cr-Commit-Position: refs/heads/master@{#473499}
Committed:
https://chromium.googlesource.com/chromium/src/+/7856682b892241cb9263140c5655...
==========

[commit-bot: I haz the power, 2017-05-22 03:46:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7856682b892241cb9263140c5655...