Upstream position: sticky <thead> and <tfoot> tests to WPT

Upstream position: sticky <thead> and <tfoot> tests to WPT

BUG=699244
Review-Url: https://codereview.chromium.org/2889683007
Cr-Commit-Position: refs/heads/master@{#475109}
Committed: https://chromium.googlesource.com/chromium/src/+/1b3ac1c0c97d7d882afda5dcf762f63050de9b57

[smcgruer, 2017-05-19 17:16:31]

smcgruer@chromium.org changed reviewers:
+ flackr@chromium.org

[smcgruer, 2017-05-25 13:35:19]

Ping for review?

[flackr, 2017-05-25 14:54:03]

lgtm

https://codereview.chromium.org/2889683007/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-thead-top.html
(right):

https://codereview.chromium.org/2889683007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-thead-top.html:56:
}
I wonder if we should also have a test for the complicated nesting case which
breaks with our current location container logic?

i.e. add
thead > tr {
  position: sticky;
  top: 30px;
}
thead > tr > th {
  position: sticky;
  top: 35px;
}

Or something weird like that.

[smcgruer, 2017-05-26 17:32:34]

On 2017/05/25 14:54:03, flackr wrote:
> lgtm
> 
>
https://codereview.chromium.org/2889683007/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-thead-top.html
> (right):
> 
>
https://codereview.chromium.org/2889683007/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-thead-top.html:56:
> }
> I wonder if we should also have a test for the complicated nesting case which
> breaks with our current location container logic?
> 
> i.e. add
> thead > tr {
>   position: sticky;
>   top: 30px;
> }
> thead > tr > th {
>   position: sticky;
>   top: 35px;
> }
> 
> Or something weird like that.

It's a good idea, I will add it to the next patch which will upstream the
nesting tests.

[smcgruer, 2017-05-26 17:43:29]

The CQ bit was checked by smcgruer@chromium.org

[smcgruer, 2017-05-26 17:43:30]

The patchset sent to the CQ was uploaded after l-g-t-m from flackr@chromium.org
Link to the patchset: https://codereview.chromium.org/2889683007/#ps20001
(title: "Upstream position: sticky <thead> and <tfoot> tests to WPT")

[commit-bot: I haz the power, 2017-05-26 17:44:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:34:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495820609795170,
"parent_rev": "373e72a7db96f15fa0adb679efb9992078500251", "commit_rev":
"1b3ac1c0c97d7d882afda5dcf762f63050de9b57"}

[commit-bot: I haz the power, 2017-05-26 20:34:44]

Description was changed from

==========
Upstream position: sticky <thead> and <tfoot> tests to WPT

BUG=699244
==========

to

==========
Upstream position: sticky <thead> and <tfoot> tests to WPT

BUG=699244

Review-Url: https://codereview.chromium.org/2889683007
Cr-Commit-Position: refs/heads/master@{#475109}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b3ac1c0c97d7d882afda5dcf762...
==========

[commit-bot: I haz the power, 2017-05-26 20:34:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b3ac1c0c97d7d882afda5dcf762...