Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2889683003: Rename TaskRunner::RunsTasksOnCurrentThread() in //components (Closed)

Created:
3 years, 7 months ago by Yeol Park
Modified:
3 years, 6 months ago
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, Eran Messeri, zea+watch_chromium.org, Peter Beverloo, yamaguchi+watch_chromium.org, oka+watch_chromium.org, chirantan+watch_chromium.org, timvolodine, asvitkine+watch_chromium.org, vakh+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, martijn+crwatch_martijnc.be, mac-reviews_chromium.org, johnme+watch_chromium.org, sync-reviews_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename TaskRunner::RunsTasksOnCurrentThread() in //components renamed TaskRunner::RunsTasksOnCurrentThread() to TaskRunner::RunsTasksInCurrentSequence() in //components BUG=665062 Review-Url: https://codereview.chromium.org/2889683003 Cr-Commit-Position: refs/heads/master@{#482173} Committed: https://chromium.googlesource.com/chromium/src/+/ac76448402d65a2f5dc9ccea07916f009960e0b0

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -249 lines) Patch
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/certificate_transparency/ct_policy_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/component_updater/default_component_installer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/device_event_log/device_event_log_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/domain_reliability/monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/chromeos/file_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/chromeos/resource_metadata.cc View 17 chunks +23 lines, -23 lines 0 comments Download
M components/gcm_driver/fake_gcm_client.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 63 chunks +71 lines, -71 lines 0 comments Download
M components/history/core/browser/top_sites_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/keyed_service/core/refcounted_keyed_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/leak_detector/leak_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/url_blacklist_manager.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M components/policy/core/common/async_policy_loader.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M components/policy/core/common/cloud/external_policy_data_updater.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/policy_header_io_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/resource_cache.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M components/policy/core/common/policy_loader_ios.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_database.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/safe_browsing_db/v4_store.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M components/sessions/core/base_session_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/shared_change_processor.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M components/sync/engine/fake_sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/timers/alarm_timer_chromeos.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/update_client/background_downloader_win.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M components/update_client/component.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M components/update_client/crx_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/url_request_post_interceptor.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 20 chunks +49 lines, -49 lines 0 comments Download
M components/wallpaper/wallpaper_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Yeol Park
PTAL :) blundell@, jochen@ for //components
3 years, 7 months ago (2017-05-17 10:33:00 UTC) #3
blundell
https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc File components/storage_monitor/portable_device_watcher_win.cc (right): https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc#newcode317 components/storage_monitor/portable_device_watcher_win.cc:317: base::ThreadRestrictions::AssertIOAllowed(); Is this the canonical change to make here?
3 years, 7 months ago (2017-05-17 15:24:52 UTC) #4
Yeol Park
https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc File components/storage_monitor/portable_device_watcher_win.cc (right): https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc#newcode317 components/storage_monitor/portable_device_watcher_win.cc:317: base::ThreadRestrictions::AssertIOAllowed(); I used TaskScheduler instead of blocking pool and ...
3 years, 7 months ago (2017-05-19 04:34:51 UTC) #5
blundell
https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc File components/storage_monitor/portable_device_watcher_win.cc (right): https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc#newcode317 components/storage_monitor/portable_device_watcher_win.cc:317: base::ThreadRestrictions::AssertIOAllowed(); On 2017/05/19 04:34:51, Yeol Park wrote: > I ...
3 years, 7 months ago (2017-05-22 09:29:40 UTC) #6
Yeol Park
https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc File components/storage_monitor/portable_device_watcher_win.cc (right): https://codereview.chromium.org/2889683003/diff/1/components/storage_monitor/portable_device_watcher_win.cc#newcode317 components/storage_monitor/portable_device_watcher_win.cc:317: base::ThreadRestrictions::AssertIOAllowed(); Done in https://codereview.chromium.org/2943923002 :)
3 years, 6 months ago (2017-06-23 04:59:21 UTC) #7
blundell
rubberstamp lgtm assuming this is a straight search-and-replace at this point; if it's not, please ...
3 years, 6 months ago (2017-06-23 13:32:00 UTC) #8
blundell
Thanks for taking care of the other issue, btw!
3 years, 6 months ago (2017-06-23 13:32:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889683003/20001
3 years, 6 months ago (2017-06-25 13:05:27 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-25 14:40:10 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac76448402d65a2f5dc9ccea0791...

Powered by Google App Engine
This is Rietveld 408576698