Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2889663002: Modify DEPS file to recurse into V8's DEPS.chromium. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by stephen.kyle
Modified:
4 months, 1 week ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify DEPS file to recurse into V8's DEPS.chromium. This picks up the simulator test files for ARM64. BUG=718439

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
stephen.kyle
4 months, 1 week ago (2017-05-17 12:15:46 UTC) #7
stephen.kyle
4 months, 1 week ago (2017-05-17 12:16:11 UTC) #9
Nico
On the bug: "ARM64 NEON support in V8 depends on an external git repository for ...
4 months, 1 week ago (2017-05-17 15:55:46 UTC) #11
martyn.capewell
Large is 72MB total, which is too large to go through codereview.chromium.org, but I don't ...
4 months, 1 week ago (2017-05-17 16:10:17 UTC) #12
Nico
4 months, 1 week ago (2017-05-17 18:37:53 UTC) #13
On 2017/05/17 16:10:17, martyn.capewell wrote:
> Large is 72MB total, which is too large to go through
http://codereview.chromium.org,
> but I don't think they're large compared to the rest of the code base.
> 
> The repository contains a set of header files with reference outputs, used to
> test the ARM64 simulator matches the hardware.  The largest file is 1.2MB, and
> there are about 1400 files in the repository.

Yeah, we don't want everyone on linux download 72MB of stuff most people won't
use. (Similar recent discussion on
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/WB9FME7IVZM
for example)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b