Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2889653005: MD Settings: Shorten page fade transitions (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

MD Settings: Shorten page fade transitions Expanding or collapsing a section takes 350ms, but fading the new content in and the old content out takes 500ms. This is a contributing factor to the overlap seen when closing a section, as the old section is still visible when the collapse animation has completed. Shortening the fade duration to match the expand/collapse animation makes that overlap much less likely to occur. It also makes the animations appear snappier, IMO -- if the page is still fading after expanding, it looks slugging. This re-implements the fade animations, rather than programmatically changing the neon-animated-pages' transition durations for the existing fade-in-animation/fade-out-animation. The latter is not possible due to https://github.com/PolymerElements/neon-animation/issues/209. R=dbeam@chromium.org BUG=716680 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856223007 Cr-Original-Commit-Position: refs/heads/master@{#469582} Review-Url: https://codereview.chromium.org/2889653005 . Cr-Commit-Position: refs/branch-heads/3071@{#590} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/056d542cd1bdab430bd4d39df75e47cbc941cd87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -6 lines) Patch
M chrome/browser/resources/settings/animation/compiled_resources2.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/animation/fade_animations.html View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/animation/fade_animations.js View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_animated_pages.html View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_animated_pages.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Dan Beam
3 years, 7 months ago (2017-05-16 23:00:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
056d542cd1bdab430bd4d39df75e47cbc941cd87.

Powered by Google App Engine
This is Rietveld 408576698