Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2889653003:
media: Add test to ensure encrypted VP9 profile 1/2/3 are not supported (Closed)
Descriptionmedia: Add test to ensure encrypted VP9 profile 1/2/3 are not supported
The support in Chromium is still under development. Adding test to make
sure we don't accidentally enable them before we can actually handle
them.
BUG=707128
TEST=This CL addes more test cases.
Review-Url: https://codereview.chromium.org/2889653003
Cr-Commit-Position: refs/heads/master@{#472289}
Committed: https://chromium.googlesource.com/chromium/src/+/75d512cf05fd123c31d73ff55bc782e3cde766d6
Patch Set 1 #
Total comments: 2
Patch Set 2 : comments #Messages
Total messages: 27 (15 generated)
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xhwang@chromium.org changed reviewers: + kqyang@chromium.org
xhwang@chromium.org changed reviewers: + kqyang@chromium.org
PTAL
PTAL
chcunningham: FYI
https://codereview.chromium.org/2889653003/diff/1/chrome/browser/media/encryp... File chrome/browser/media/encrypted_media_supported_types_browsertest.cc (right): https://codereview.chromium.org/2889653003/diff/1/chrome/browser/media/encryp... chrome/browser/media/encrypted_media_supported_types_browsertest.cc:138: invalid_codecs_.push_back("vp09.02.10.08"); The last digit is bit_depth for profile 2 and 3, should be either 10 or 12.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
https://codereview.chromium.org/2889653003/diff/1/chrome/browser/media/encryp... File chrome/browser/media/encrypted_media_supported_types_browsertest.cc (right): https://codereview.chromium.org/2889653003/diff/1/chrome/browser/media/encryp... chrome/browser/media/encrypted_media_supported_types_browsertest.cc:138: invalid_codecs_.push_back("vp09.02.10.08"); On 2017/05/16 19:01:28, kqyang wrote: > The last digit is bit_depth for profile 2 and 3, should be either 10 or 12. Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by xhwang@chromium.org
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
xhwang@chromium.org changed reviewers: + chcunningham@chromium.org
chcunningham: Actually I need your approval as well!
lgtm
The CQ bit was checked by chcunningham@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494978583435160,
"parent_rev": "137e05d0105abedb195dae64225b1f7b954da5e5", "commit_rev":
"75d512cf05fd123c31d73ff55bc782e3cde766d6"}
Message was sent while issue was closed.
Description was changed from ========== media: Add test to ensure encrypted VP9 profile 1/2/3 are not supported The support in Chromium is still under development. Adding test to make sure we don't accidentally enable them before we can actually handle them. BUG=707128 TEST=This CL addes more test cases. ========== to ========== media: Add test to ensure encrypted VP9 profile 1/2/3 are not supported The support in Chromium is still under development. Adding test to make sure we don't accidentally enable them before we can actually handle them. BUG=707128 TEST=This CL addes more test cases. Review-Url: https://codereview.chromium.org/2889653003 Cr-Commit-Position: refs/heads/master@{#472289} Committed: https://chromium.googlesource.com/chromium/src/+/75d512cf05fd123c31d73ff55bc7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/75d512cf05fd123c31d73ff55bc7... |
