Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2889623002: Apply View::set_preferred_size in some more places. (Closed)

Created:
3 years, 7 months ago by Evan Stade
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, awdf+watch_chromium.org, derat+watch_chromium.org, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply View::set_preferred_size in some more places. Also fix a botched attempt to simplify SystemMenuButton. BUG=723080 Review-Url: https://codereview.chromium.org/2889623002 Cr-Commit-Position: refs/heads/master@{#472646} Committed: https://chromium.googlesource.com/chromium/src/+/25c5c824f966d42bf627fd53adb3ef9da3b0cb61

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix SystemMenuButton #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -98 lines) Patch
M ash/system/tray/system_menu_button.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M ash/system/tray/tray_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_constants.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/arc_app_dialog_view.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout_unittest.cc View 4 chunks +24 lines, -34 lines 0 comments Download
M components/constrained_window/constrained_window_views_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/message_center/views/custom_notification_view_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M ui/views/controls/button/image_button.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/image_button.cc View 1 2 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Evan Stade
3 years, 7 months ago (2017-05-16 22:05:55 UTC) #6
sky
LGTM
3 years, 7 months ago (2017-05-17 17:38:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889623002/40001
3 years, 7 months ago (2017-05-17 20:56:42 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:45:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25c5c824f966d42bf627fd53adb3...

Powered by Google App Engine
This is Rietveld 408576698