Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2889613003: Remove unnecessary lock in AOC; use atomic ref count instead. (Closed)

Created:
6 months, 1 week ago by DaleCurtis
Modified:
6 months, 1 week ago
Reviewers:
miu
CC:
chromium-reviews, feature-media-reviews_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary lock in AOC; use atomic ref count instead. Trace on b/37638202 shows this something stuck in AudioOutputController::OnMoreData() so remove the lock in favor of an atomic op. BUG=none TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2889613003 Cr-Commit-Position: refs/heads/master@{#472735} Committed: https://chromium.googlesource.com/chromium/src/+/3994a55ffa417d2f7065742b47b24c468cbfa76f

Patch Set 1 #

Patch Set 2 : Fix comments. #

Total comments: 1

Messages

Total messages: 10 (6 generated)
DaleCurtis
6 months, 1 week ago (2017-05-16 23:43:00 UTC) #3
miu
lgtm https://codereview.chromium.org/2889613003/diff/20001/media/audio/audio_output_controller.cc File media/audio/audio_output_controller.cc (right): https://codereview.chromium.org/2889613003/diff/20001/media/audio/audio_output_controller.cc#newcode278 media/audio/audio_output_controller.cc:278: std::unique_ptr<AudioBus> copy(AudioBus::Create(params_)); BTW--The call to AudioBus::Create() here could ...
6 months, 1 week ago (2017-05-18 03:06:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889613003/20001
6 months, 1 week ago (2017-05-18 03:08:00 UTC) #7
commit-bot: I haz the power
6 months, 1 week ago (2017-05-18 08:13:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3994a55ffa417d2f7065742b47b2...

Powered by Google App Engine
This is Rietveld efc10ee0f