Remove unnecessary lock in AOC; use atomic ref count instead.

Remove unnecessary lock in AOC; use atomic ref count instead.

Trace on b/37638202 shows this something stuck in
AudioOutputController::OnMoreData() so remove the lock in favor
of an atomic op.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2889613003
Cr-Commit-Position: refs/heads/master@{#472735}
Committed: https://chromium.googlesource.com/chromium/src/+/3994a55ffa417d2f7065742b47b24c468cbfa76f

[DaleCurtis, 2017-05-16 23:42:22]

Description was changed from

==========
Remove unnecessary lock in AOC; use atomic ref count instead.

Trace on b/37638202 shows this something stuck in this code path;
so remove the lock in favor of an atomic op.

BUG=none
TEST=none
==========

to

==========
Remove unnecessary lock in AOC; use atomic ref count instead.

Trace on b/37638202 shows this something stuck in this code path;
so remove the lock in favor of an atomic op.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[DaleCurtis, 2017-05-16 23:42:59]

dalecurtis@chromium.org changed reviewers:
+ miu@chromium.org

[DaleCurtis, 2017-05-16 23:44:42]

Description was changed from

==========
Remove unnecessary lock in AOC; use atomic ref count instead.

Trace on b/37638202 shows this something stuck in this code path;
so remove the lock in favor of an atomic op.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove unnecessary lock in AOC; use atomic ref count instead.

Trace on b/37638202 shows this something stuck in
AudioOutputController::OnMoreData() so remove the lock in favor
of an atomic op.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[miu, 2017-05-18 03:06:28]

The CQ bit was checked by miu@chromium.org

[miu, 2017-05-18 03:06:29]

lgtm

https://codereview.chromium.org/2889613003/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_controller.cc (right):

https://codereview.chromium.org/2889613003/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_controller.cc:278: std::unique_ptr<AudioBus>
copy(AudioBus::Create(params_));
BTW--The call to AudioBus::Create() here could also be a source of problems
since the memory allocator might acquire a global lock. Unfortunately, aside
from creating a pool of AudioBus's ahead-of-time, I don't see another way around
this. AFAIK, this has never caused a problem, though...

[commit-bot: I haz the power, 2017-05-18 03:08:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 08:13:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495076788938510,
"parent_rev": "2b0271854f085af5d04c60907258ccfa3d7984e2", "commit_rev":
"3994a55ffa417d2f7065742b47b24c468cbfa76f"}

[commit-bot: I haz the power, 2017-05-18 08:13:53]

Description was changed from

==========
Remove unnecessary lock in AOC; use atomic ref count instead.

Trace on b/37638202 shows this something stuck in
AudioOutputController::OnMoreData() so remove the lock in favor
of an atomic op.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove unnecessary lock in AOC; use atomic ref count instead.

Trace on b/37638202 shows this something stuck in
AudioOutputController::OnMoreData() so remove the lock in favor
of an atomic op.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2889613003
Cr-Commit-Position: refs/heads/master@{#472735}
Committed:
https://chromium.googlesource.com/chromium/src/+/3994a55ffa417d2f7065742b47b2...
==========

[commit-bot: I haz the power, 2017-05-18 08:13:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3994a55ffa417d2f7065742b47b2...