Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2889593004: Unbundle freetype (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbundle freetype This CL makes it easier for Linux distribution packagers to use system freetype library, by providing a drop-in replacement GN file. build/linux/unbundle is a separate directory tree, so that regular Chromium developers don't need to worry about this configuration. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README?dr for more context. BUG=551343 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2889593004 . Cr-Commit-Position: refs/heads/master@{#472528} Committed: https://chromium.googlesource.com/chromium/src/+/aac85c0cf8dd4ae61c5a946167ef59d3aae635cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -0 lines) Patch
A build/linux/unbundle/freetype.gn View 1 chunk +125 lines, -0 lines 0 comments Download
M build/linux/unbundle/replace_gn_files.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-17 12:46:29 UTC) #2
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-17 18:22:13 UTC) #3
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-17 19:26:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aac85c0cf8dd4ae61c5a946167ef59d3aae635cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698