Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2889573002: Fix the ContentSuggestionsCell reuse cleanup (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
lody
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the ContentSuggestionsCell reuse cleanup The ContentSuggestionsCell can have different layout. The -prepareForReuse should do cleanup to make sure the layout used after this call is small enough to fit all possible layout. BUG=722828 Review-Url: https://codereview.chromium.org/2889573002 Cr-Commit-Position: refs/heads/master@{#472096} Committed: https://chromium.googlesource.com/chromium/src/+/592962e6471424fd4c33950d7345fb6dca802f11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 7 months ago (2017-05-16 13:57:28 UTC) #2
lody
lgtm
3 years, 7 months ago (2017-05-16 13:59:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889573002/1
3 years, 7 months ago (2017-05-16 14:00:35 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 14:12:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/592962e6471424fd4c33950d7345...

Powered by Google App Engine
This is Rietveld 408576698